Skip to content

feat: add support for pnpm - #1629

Open
neilime wants to merge 6 commits into
mainfrom
feat/supports-pnpm
Open

feat: add support for pnpm#1629
neilime wants to merge 6 commits into
mainfrom
feat/supports-pnpm

Conversation

@neilime

@neilime neilime commented Sep 29, 2025

Copy link
Copy Markdown
Member

No description provided.

@neilime neilime self-assigned this Sep 29, 2025
@neilime
neilime force-pushed the feat/supports-pnpm branch 3 times, most recently from 42c1287 to 4263c23 Compare September 29, 2025 16:33

@neilime neilime left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot finialize the work: fix build make tests passing

Copilot AI commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

@neilime I've opened a new pull request, #1659, to work on those changes. Once the pull request is ready, I'll request review from you.

@neilime neilime left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot migrate this repo to use pnpm instead of npm

Copilot AI commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

@neilime I've opened a new pull request, #1660, to work on those changes. Once the pull request is ready, I'll request review from you.

@neilime
neilime force-pushed the feat/supports-pnpm branch 5 times, most recently from 2054ecc to c55bc1a Compare November 15, 2025 06:45
@codecov

codecov Bot commented Nov 15, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.70588% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.97%. Comparing base (c5bb0c1) to head (67753df).
⚠️ Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
...vices/package-manager/PnpmPackageManagerAdapter.ts 75.00% 11 Missing ⚠️
packages/core/src/tests/workspace-root.ts 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1629      +/-   ##
==========================================
- Coverage   88.41%   87.97%   -0.44%     
==========================================
  Files          37       36       -1     
  Lines        1027     1073      +46     
  Branches      193      202       +9     
==========================================
+ Hits          908      944      +36     
- Misses        118      128      +10     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@neilime
neilime force-pushed the feat/supports-pnpm branch 2 times, most recently from 7c18d34 to e22c9cf Compare December 4, 2025 13:51
@escemi-tech escemi-tech deleted a comment from github-actions Bot Feb 3, 2026
@neilime
neilime force-pushed the feat/supports-pnpm branch 2 times, most recently from 569c095 to a573995 Compare February 10, 2026 08:27
@neilime
neilime force-pushed the main branch 4 times, most recently from 8a30ce6 to c052b8c Compare February 10, 2026 11:21
@neilime
neilime force-pushed the feat/supports-pnpm branch 8 times, most recently from 507ef6d to 8303605 Compare June 4, 2026 12:14
Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>
@neilime

neilime commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

@copilot resolve the merge conflicts on this branch.

Copilot AI and others added 2 commits August 4, 2026 05:32
Co-authored-by: neilime <314088+neilime@users.noreply.github.com>
Co-authored-by: neilime <314088+neilime@users.noreply.github.com>

Copilot AI commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@copilot finialize the work: fix build make tests passing

Build and tests are now all passing. Here's a summary of what was fixed:

  • Build: Added @types/node and vitest as devDependencies to @ts-dev-tools/react (needed for TypeScript compilation with pnpm's strict isolation)
  • Snapshots: Updated all test snapshots to reflect pnpm-based behavior:
    • Git hooks now use pnpm run instead of npm run (since test projects have pnpm-lock.yaml)
    • SymlinkDependenciesService now symlinks individual packages (pnpm has per-package node_modules)
    • test:ci script uses pnpm run test:cov in unit tests (pnpm projects), npm run test:cov in e2e tests (npm projects)
    • Added jsdom peer dependency resolution line to core e2e snapshots
    • Updated biome schema (preset: "recommended" for migration spec, recommended: true for e2e)
    • Updated duplicate dependency lists to include vitest (now exposed via pnpm)
  • Tests: Filtered npm warn allow-scripts warnings from stderr assertions (npm 11 behavior)

All 127 tests pass (core: 120, react: 7).

@neilime

neilime commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

@copilot resolve the merge conflicts on this branch.

# Conflicts:
#	package-lock.json
#	packages/react/package.json

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>

Copilot AI commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts on this branch.

Merge conflicts resolved in commit 3961936:

  • package-lock.json: kept deleted (repo migrated to pnpm)
  • packages/react/package.json: kept workspace:* reference for @ts-dev-tools/core and devDependencies (@types/node, vitest), while picking up updated package versions from main

@neilime

neilime commented Aug 16, 2026

Copy link
Copy Markdown
Member Author

@copilot resolve the merge conflicts on this branch.

# Conflicts:
#	package-lock.json
#	packages/react/package.json

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>

Copilot AI commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts on this branch.

Merge conflicts resolved in commit c858fc1:

  • package-lock.json: kept deleted (repo migrated to pnpm)
  • packages/react/package.json: kept workspace:* for @ts-dev-tools/core and devDependencies, picked up updated versions from main (@types/react ^19.2.18, @types/react-dom ^19.2.4, jsdom ^30.0.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants