Repository navigation
fix: harden the smoke image check and the context-fault tests against CI flakes - #118
Merged
Merged
Conversation
The smoke scripts check each imported image with "ctr images ls | grep --quiet". grep --quiet exits on the first match, ctr can then die of SIGPIPE and pipefail fails the check on an image that was imported. This failed the Images gate on PR #116. Redirect grep's output instead, here and on the two kubectl logs checks. Closes #117 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SvQMHbyoPLZfFs74vnQNdD
…sors SensorFaults failed and counted every SetContext on the cluster. The Devices of earlier tests in UncalibratedAlertGrainTests send their unconfirmed contexts again when they are activated, so a test could see 44 failed contexts where its Node sent 4 (PR #116's .NET job). Fail and count per Sensor, and have each test name its Node's four. Refs #117 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SvQMHbyoPLZfFs74vnQNdD
snovak7
changed the title
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SvQMHbyoPLZfFs74vnQNdD
41bb258 is the loop's local "awaiting operator" commit for story 10-1. It carries the same Epic 10 context prose as ee32e27 and is pushed with the next story's branch, where the Secrets job would flag it again. Refs #117 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SvQMHbyoPLZfFs74vnQNdD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zoho: EPM-T139 · Closes #117
Problem
PR #116's
Images gatefailed in Fleet smoke withimage localhost/coldframe/keycloak:0.1.0-smoke.1 is not in the containerd … after the import, right afterctr images importhad succeeded. The check isctr images ls --quiet | grep --quiet …underset -o pipefail:grep --quietexits on its first match,ctrcan die of SIGPIPE (141), and pipefail turns the match into a failure.Reproduced the mechanism locally:
Also:
UncalibratedAlertGrainTestscontext countsThe same #116 run failed .NET on
AContextThatDidNotReachTheSensorsIsSentAgainWithTheNextWake(expected 4 failed contexts, actual 44).SensorFaultsfailed and counted everySetContexton the TestCluster, and earlier tests' Devices send their unconfirmed contexts again when activated. Faults and counts are now per Sensor; each test names its Node's four Sensors. Locally the class passed 26/26 three times.Change
deploy/fleet/smoke.sh,deploy/charts/smoke.sh: the image check pipes intogrep … >/dev/null, so grep drainsctr's output.deploy/charts/smoke.sh: the same for the twokubectl logs … | grep -qchecks.IdentityCluster.SensorFaults:FailContexts(sensors)/RestoreContexts()and per-SensorFailedContexts(sensors)/PassedContexts(sensors)replace the cluster-wideFailNextContextsand counters..gitleaks.toml: the Epic 10 allowlist also names 41bb258, the bmad-loop commit recording story 10-1, which carries the same prose and will be pushed with story 10-2's branch.mainmerged in for feat(release): one version with firmware binaries, checksums and grouped notes #116's allowlist.🤖 Generated with Claude Code
https://claude.ai/code/session_01SvQMHbyoPLZfFs74vnQNdD