Repository navigation
docs(firmware): follow-up review fixes for the firmware reference - #128
Merged
snovak7 merged 1 commit intoOct 20, 2026
Merged
Conversation
- WIFI_SECURITY_WPA2_PERSONAL proto comment covers WPA and mixed WPA/WPA2, matching the Hub's mapping (comment-only) - deep-sleep.md cites AD-17 by its real title - identity.md labels the release-guard excerpt as the Node's - ble-setup.md reconciles "ATT MTU minus 3" with the crate's MTU - 4 - buttons.md names take_pins! as a macro - Node and Hub READMEs link the firmware reference - story 10-4 spec: follow-up review triage log and run result Closes #127 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017VX7RCLKLixMA3yYfkJNZm
snovak7
deleted the
docs/epm-t143-gh127-follow-up-review-firmware-learning
branch
October 20, 2026 12:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up review pass on the firmware learning reference (story 10-4, first pass in #126). Four review layers re-checked the diff since the baseline. The edge-case and verification-gap layers found nothing, and a script check confirmed that every backticked identifier in
docs/firmware/exists in the code. Six low-severity wording fixes:setup.proto: theWIFI_SECURITY_WPA2_PERSONALcomment covers WPA and mixed WPA/WPA2, as the Hub maps them (comment-only).deep-sleep.md: AD-17 cited by its real title.identity.md: the release-guard excerpt is labelled as the Node's.ble-setup.md: "ATT MTU minus 3" reconciled with the crate's "ATT MTU − 4".buttons.md:take_pins!named as a macro.Closes #127
Test plan
RUSTDOCFLAGS="-D warnings" cargo doc --no-deps --locked --features coldframe-hal/mockover the 7packages/rscratescargo fmt --check,cargo clippy --workspace --all-targets --locked -- -D warningscargo test --workspace --locked(350 passed)docs/check-links.sh(821 resolve),docs/check-commands.sh --list,docs/test.sh(50/50)buf lint/buf breaking(not installed locally; the change is comment-only, so CI covers it)🤖 Generated with Claude Code
https://claude.ai/code/session_017VX7RCLKLixMA3yYfkJNZm