Clippy fixes

Fixes came from new rust version and not from the changes in this branch

Author: AmmarAbouZor

crates/app/src/session/service/export.rs

@@ -246,7 +246,8 @@ impl SessionService {
                 if len == 0 {
                     Ok(Vec::new())
                 } else {
-                    Ok(vec![0..=(len as u64 - 1)])
+                    let rng: RangeInclusive<_> = 0..=(len as u64 - 1);
+                    Ok(vec![rng])
                 }
             }
             ExportTarget::Indexed => {

crates/core/dlt_tools/src/lib.rs

@@ -153,7 +153,7 @@ mod tests {
                 assert_eq!("test3.txt", files.get(2).unwrap().name);
             }
             Err(error) => {
-                panic!("{}", format!("{error}"));
+                panic!("{error}");
             }
         }
     }
@@ -170,7 +170,7 @@ mod tests {
                 assert_eq!(files.len(), 0);
             }
             Err(error) => {
-                panic!("{}", format!("{error}"));
+                panic!("{error}");
             }
         }
     }
@@ -195,7 +195,7 @@ mod tests {
                 assert_eq!("test2.txt", files.first().unwrap().name);
             }
             Err(error) => {
-                panic!("{}", format!("{error}"));
+                panic!("{error}");
             }
         }
     }
@@ -217,12 +217,12 @@ mod tests {
                         assert_eq!(size, 18);
                     }
                     Err(error) => {
-                        panic!("{}", format!("{error}"));
+                        panic!("{error}");
                     }
                 }
             }
             Err(error) => {
-                panic!("{}", format!("{error}"));
+                panic!("{error}");
             }
         }
 
@@ -246,12 +246,12 @@ mod tests {
                         assert_eq!(size, 0);
                     }
                     Err(error) => {
-                        panic!("{}", format!("{error}"));
+                        panic!("{error}");
                     }
                 }
             }
             Err(error) => {
-                panic!("{}", format!("{error}"));
+                panic!("{error}");
             }
         }
     }
@@ -279,12 +279,12 @@ mod tests {
                         assert_eq!(size, 6);
                     }
                     Err(error) => {
-                        panic!("{}", format!("{error}"));
+                        panic!("{error}");
                     }
                 }
             }
             Err(error) => {
-                panic!("{}", format!("{error}"));
+                panic!("{error}");
             }
         }
 
@@ -309,12 +309,12 @@ mod tests {
                         assert_eq!(size, 6);
                     }
                     Err(error) => {
-                        panic!("{}", format!("{error}"));
+                        panic!("{error}");
                     }
                 }
             }
             Err(error) => {
-                panic!("{}", format!("{error}"));
+                panic!("{error}");
             }
         }
 
@@ -344,12 +344,12 @@ mod tests {
                         assert_eq!(size, 6);
                     }
                     Err(error) => {
-                        panic!("{}", format!("{error}"));
+                        panic!("{error}");
                     }
                 }
             }
             Err(error) => {
-                panic!("{}", format!("{error}"));
+                panic!("{error}");
             }
         }
 

crates/core/processor/src/map.rs

@@ -25,7 +25,7 @@ impl FiltersStats {
     }
 
     pub fn increment(&mut self, alias: impl Into<String>, value: Option<u64>) {
-        *self.stats.entry(alias.into()).or_insert(0) += value.map_or(1, |v| v);
+        *self.stats.entry(alias.into()).or_insert(0) += value.unwrap_or(1);
     }
 }
 
@@ -201,8 +201,8 @@ impl SearchMap {
     }
 
     pub fn set(&mut self, matches: Option<Vec<stypes::FilterMatch>>, stats: Option<FiltersStats>) {
-        self.matches = matches.map_or(vec![], |m| m);
-        self.stats = stats.map_or(FiltersStats::default(), |s| s);
+        self.matches = matches.unwrap_or_default();
+        self.stats = stats.unwrap_or_default();
     }
 
     pub fn append(&mut self, matches: &mut Vec<stypes::FilterMatch>) -> usize {

crates/core/session/src/handlers/observing/logs_writer.rs

@@ -56,6 +56,9 @@ impl LogsWriter {
         }
         if !self.attachments.is_empty() {
             // Draining into a new vector preserves the capacity of the internal buffer.
+            // `mem::take` would hand the allocation away and force the buffer to regrow
+            // on each iteration.
+            #[allow(clippy::drain_collect)]
             let attachments = self.attachments.drain(..).collect();
             self.state.add_attachments(attachments)?;
         }