Fix clippy warnings for version 1.97

Author: AmmarAbouZor

crates/app/src/host/common/colors.rs

@@ -201,9 +201,9 @@ pub fn notification_error_color(dark_mode: bool) -> Color32 {
 /// Stroke used for the active log-table indicator.
 pub fn active_log_table_indicator(dark_mode: bool) -> Stroke {
     if dark_mode {
-        Stroke::new(2.0, MAIN_ACCENT_STROKE_DARK.gamma_multiply_u8(200))
+        Stroke::new(2.0_f32, MAIN_ACCENT_STROKE_DARK.gamma_multiply_u8(200))
     } else {
-        Stroke::new(3.0, MAIN_ACCENT_STROKE_LIGHT.gamma_multiply_u8(170))
+        Stroke::new(3.0_f32, MAIN_ACCENT_STROKE_LIGHT.gamma_multiply_u8(170))
     }
 }
 

crates/app/src/host/ui/banners/update.rs

@@ -44,7 +44,7 @@ pub fn render(
 
             let accent_stroke = colors::main_accent_stroke(ui.visuals().dark_mode);
             Frame::window(ui.style())
-                .stroke(Stroke::new(1.0, accent_stroke))
+                .stroke(Stroke::new(1.0_f32, accent_stroke))
                 .show(ui, |ui| {
                     ui.set_width(card_width);
 

crates/app/src/host/ui/command_palette/row.rs

@@ -82,7 +82,7 @@ fn render_title(ui: &mut Ui, title: &SearchPickerText, font_size: f32) {
         ..Default::default()
     };
     let highlight_format = TextFormat {
-        underline: Stroke::new(1.0, color),
+        underline: Stroke::new(1.0_f32, color),
         ..base_format.clone()
     };
 

crates/app/src/host/ui/notification/banner.rs

@@ -77,7 +77,7 @@ impl NotificationBanner {
 
                 let base_level_color = entry.level.color(ui.visuals().dark_mode);
                 let level_color = apply_alpha(base_level_color);
-                let stroke = Stroke::new(1.0, level_color);
+                let stroke = Stroke::new(1.0_f32, level_color);
                 let margin = Margin::same(10);
                 let content_width = (banner_width - 20.0).at_least(0.0);
                 let text_color = apply_alpha(ui.visuals().text_color());

crates/app/src/host/ui/quick_open/row.rs

@@ -102,7 +102,7 @@ fn highlighted_layout(ui: &Ui, text: &SearchPickerText, primary: bool) -> Layout
         ..Default::default()
     };
     let highlight_format = TextFormat {
-        underline: Stroke::new(1.25, color),
+        underline: Stroke::new(1.25_f32, color),
         ..base_format.clone()
     };
 

crates/app/src/session/ui/common/log_table/table.rs

@@ -264,7 +264,7 @@ pub fn render_upper_bound(ui: &mut Ui) {
             egui::Pos2::new(rect.max.x, rect.top() + 1.0),
         ],
         Stroke::new(
-            0.5,
+            0.5_f32,
             ui.style().visuals.widgets.noninteractive.fg_stroke.color,
         ),
         4.0,

crates/core/parsers/src/dlt/attachment.rs

@@ -124,45 +124,11 @@ impl FtMessageParser {
     /// * 3 DLT_RAW(bytes)
     /// * 4 DLT_STRING("FLDA")
     fn data_message(timestamp: Option<u32>, args: &[Argument]) -> Option<FtMessage<'_>> {
-        let id;
-        let packet;
-        let bytes;
-
-        if let Some(arg) = args.get(1) {
-            if let Some(value) = Self::get_number(arg) {
-                id = value;
-            } else {
-                return None;
-            }
-        } else {
-            return None;
-        }
-
-        if let Some(arg) = args.get(2) {
-            if let Some(value) = Self::get_number(arg) {
-                packet = value;
-            } else {
-                return None;
-            }
-        } else {
-            return None;
-        }
-
-        if let Some(arg) = args.get(3) {
-            if let Some(value) = Self::get_bytes(arg) {
-                bytes = value;
-            } else {
-                return None;
-            }
-        } else {
-            return None;
-        }
-
         Some(FtMessage::Data(FileData {
             timestamp,
-            id,
-            packet,
-            bytes,
+            id: Self::get_number(args.get(1)?)?,
+            packet: Self::get_number(args.get(2)?)?,
+            bytes: Self::get_bytes(args.get(3)?)?,
         }))
     }
 
@@ -174,19 +140,10 @@ impl FtMessageParser {
     /// * 1 DLT_UINT(file-id)
     /// * 2 DLT_STRING("FLFI")
     fn end_message(timestamp: Option<u32>, args: &[Argument]) -> Option<FtMessage<'_>> {
-        let id;
-
-        if let Some(arg) = args.get(1) {
-            if let Some(value) = Self::get_number(arg) {
-                id = value;
-            } else {
-                return None;
-            }
-        } else {
-            return None;
-        }
-
-        Some(FtMessage::End(FileEnd { timestamp, id }))
+        Some(FtMessage::End(FileEnd {
+            timestamp,
+            id: Self::get_number(args.get(1)?)?,
+        }))
     }
 
     /// Returns a string value from given argument, if any.
@@ -339,7 +296,7 @@ impl TempDir {
     pub fn assert_file(&self, name: &str, content: &str) {
         let path = self.dir.join(name);
         let string =
-            std::fs::read_to_string(&path).unwrap_or_else(|_| panic!("{:?} should exist", &path));
+            std::fs::read_to_string(&path).unwrap_or_else(|_| panic!("{:?} should exist", path));
         assert_eq!(string, content);
     }
 }

crates/core/parsers/src/dlt/mod.rs

@@ -49,7 +49,7 @@ impl std::fmt::Display for RangeMessage {
 }
 impl std::fmt::Display for RawMessage {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        write!(f, "[{:02X?}]", &self.content)
+        write!(f, "[{:02X?}]", self.content)
     }
 }
 

crates/core/processor/benches/mocks/mock_source.rs

@@ -35,7 +35,7 @@ impl ByteSource for MockByteSource {
         #[inline(never)]
         fn inner(_phantom: &MockByteSource) -> &[u8] {
             black_box({
-                const BYTES: [u8; 3] = [b'a', b's', b'a'];
+                const BYTES: [u8; 3] = *b"asa";
                 const REF: &[u8] = &BYTES;
 
                 REF

crates/core/processor/src/grabber/mod.rs

@@ -390,7 +390,7 @@ pub(crate) fn identify_byte_range(slots: &[Slot], lines: &LineRange) -> Option<F
     let maybe_end_slot = identify_end_slot_simple(slots, last_line_index);
     trace!(
         "(maybe_start_slot, maybe_end_slot): ({:?}, {:?})",
-        &maybe_start_slot, &maybe_end_slot
+        maybe_start_slot, maybe_end_slot
     );
     match (maybe_start_slot, maybe_end_slot) {
         (Some((start_slot, _)), Some((end_slot, _))) => {