Repository navigation
Reorder and Move Filters with Drag and Drop + Improve Multiple Files Drag and Drop - #2618
Merged
Merged
Conversation
* Filters and charts can be reordered using drag and drop. * Compatible items can be moved between filters and charts using drag and drop. * Stale edit states in filters side panel UI is checked and removed.
* Split filters side panel view into multiple sub-modules. * Check code style in the modules improving the code without logic changes. * Remove low value unit tests
Align drop highlighting with pointer positions, allowing to draw the highlight line on both top and bottom of rows to match drag and drop behavior for filters in running sessions. Painting the highlight will happen after finishing painting the table to avoid table clipping. Improve handling of faint highlight color for no-op destinations Extend comments in file documenting the reasons for implementation decisions.
itsmesamster
approved these changes
Jul 20, 2026
itsmesamster
left a comment
itsmesamster
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. Kindly proceed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes: #2571
It adds support for drag and drop in filters side panel for running sessions providing the following:
This PR also includes:
filters.rsfile splitting it into multiple sub-modules and removing low-signal unit tests