Repository navigation
Add Scoped Search Inside Search Results - #2620
Merged
Merged
Conversation
* This feature isn't planned to be provided for users since they can jump to the log in main table via clicking on the log entry. * Remove breadcrumb implementation, public APIs and all tests. * Bookmark API simplified as it can't fail anymore.
* Improve the code to nested search avoiding linear searches and defining names structs for the API * Extend unit and integration tests for nested search
* Add menu entry for showing the nested search shell * Shell is triggered via ctrl+shift+f * Render shell controls and handle closing with `escape` key. * Refactor: Move handling session shortcuts to their own sub-module * Move filters shortcut to ctrl+shift+s
Replace the primary-search-only nearest lookup with a binary lookup over the complete search and bookmark union. Use explicit indexed-row coordinates across core, service, and UI APIs, preserve delayed table scrolling, and remove obsolete nearest-position types and operation dispatch. Cover ties, boundaries, interleaving, overlap, bookmark-only maps, unsorted insertion, and u64 extremes. Add unit tests to cover all edge-cases
* Nested search shell sends commands to service which will direct the request to core and send the results back. * UI handles the results and updating its state and scrolling to logs * Adjust '[' and ']' keybindings to consider active nested search
Attachment struct is fairly large making all message reserved too much space than needed for most of them.
* Extend highlighting for logs in both logs and search table with nested search highlighting * Nested search will override the existing highlighting in overlap cases
Using brackets shortcuts caused the shell to flicker as shortcut changed pending state before rendering the frame. To solve this we introduced pending commands for the shortcuts so it's possible for shortcuts to defer their command to after rendering the current UI frame
- Layer Quick Open and Command Palette above the nested-search shell. - Delay nested-search progress indication until a request remains pending for 250 ms. - Tie progress timing to correlated requests and preserve it across stale responses. - Emit an info notification for every valid nested search with no matches. - Refocus a visible, unfocused nested-search input instead of closing and resetting it. - Preserve deferred focus while a pending request keeps the editor disabled. - Handle Escape locally and close only when the nested-search input owns focus. - Keep Escape available to other focused text inputs and host overlays. - Compute nested-search visibility only when the toggle shortcut is consumed. - Remove unused nested-search status state and status-only tests. - Add regressions for delayed progress, no-match notification, focus, pending focus, and Escape ownership.
Check if nested search is active when switching tabs and focus its input text instead of the main search input if opened
* Add animated bottom border for the pending state * Improve the size and the look and feel for UI elements
* Ensure the current filter is picker for next/previous navigation. * Disable next/prev on empty queries * Disable nested search for bookmarks only * Add notes in code to document accepting blocking state main task for nested searches until we see that this is making issues for users
* Retry nested matching with ANSI codes stripped when raw matching fails. * Use memchr to keep escape detection fast and avoid parsing normal lines.
Extend search documentation with section for nested search including a video
AmmarAbouZor
changed the title
itsmesamster
requested changes
Aug 5, 2026
* Match ANSI-containing lines against visible text only. * Add regression coverage.
itsmesamster
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #2604
It adds nested scoped search for finding matches within filtered logs. It also includes several fixes and improvements to the core implementation.
It includes:
Ctrl+Shift+f.Breadcrumbcode as this feature won't be implemented in Chipmunk 4 anymore.