Repository navigation
Improve temp files handling and cleanup - #2639
Merged
Merged
Conversation
Replace the age-based sweep of leftover session files with explicit ownership, so temp files are removed when their owner goes away instead of after 30 days. To achieve this we are using OS lock files, creating one lock and directory per running chipmunk instance. On start we scan chipmunk tmp dir for leftover and try to claim them which means that there are no other chipmunk instance that is using them right now. So they are safe to clean. The current solution still support the previous time-based approach for the remaining files and it will fallback to it in case lock files aren't supported in the running environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #2638
It replaces the age-based sweep of leftover session files with explicit ownership, so temp files are removed when their owner goes away instead of after 30 days.
To achieve this we are using OS lock files, creating one lock and directory per running chipmunk instance.
On start we scan chipmunk tmp dir for leftover and try to claim them which means that there are no other chipmunk instance that is using them right now. So they are safe to clean.
The current solution still support the previous time-based approach for the remaining files and it will fallback to it in case lock files aren't supported in the running environment.