opentelemetry-instrumentation-genai-qwen-agent: support strict typing (open-telemetry#366)

* chore(qwen-agent): enable strict pyright type checking

Add the package to the pyright include list and exclude its tests and
examples, following the progressive rollout the config already describes.

Strict mode reported eight errors in utils.py, all from isinstance()
narrowing producing dict[Unknown, Unknown] / list[Unknown]. Narrow those
with cast(dict[str, Any], ...) and cast(list[Any], ...), matching the
existing idiom in the agno package. No behavior change.

Assisted-by: Claude Opus 5

* Add changelog fragment for strict typing support

* chore(qwen-agent): type message elements instead of casting to Any

The strict-mode narrowing was done with cast(list[Any], ...), which
satisfies pyright but throws away the element type. qwen-agent's own
Message and ContentItem describe those elements, so annotate the
signatures with them (under TYPE_CHECKING, since qwen-agent is an
optional dependency) and let pyright narrow the isinstance checks on
its own. All five list casts are gone as a result.

---------

Co-authored-by: Liudmila Molkova <neskazu@gmail.com>

Author: Yigtwxx

instrumentation/opentelemetry-instrumentation-genai-qwen-agent/.changelog/366.added

@@ -0,0 +1 @@
+Support strict typing: the package is now covered by the repository pyright configuration.

instrumentation/opentelemetry-instrumentation-genai-qwen-agent/src/opentelemetry/instrumentation/genai/qwen_agent/utils.py

@@ -8,7 +8,7 @@
 
 import json
 import logging
-from typing import Any
+from typing import TYPE_CHECKING, Any, cast
 
 from opentelemetry.util.genai.handler import TelemetryHandler
 from opentelemetry.util.genai.invocation import AgentInvocation
@@ -21,6 +21,15 @@
     ToolCallResponse,
 )
 
+if TYPE_CHECKING:
+    from qwen_agent.llm.schema import ContentItem, Message
+
+    # qwen-agent accepts a ``Message`` or a plain dict wherever a message or a
+    # content item is expected and normalizes them internally, so both shapes
+    # reach the instrumented methods.
+    QwenMessage = Message | dict[str, Any]
+    QwenContentItem = ContentItem | dict[str, Any]
+
 _logger = logging.getLogger(__name__)
 
 
@@ -31,8 +40,9 @@ def _field_value(value: Any, *names: str) -> Any:
 
     for name in names:
         if isinstance(value, dict):
-            if name in value:
-                return value[name]
+            mapping = cast(dict[str, Any], value)
+            if name in mapping:
+                return mapping[name]
             continue
 
         attr_value = getattr(value, name, None)
@@ -51,7 +61,7 @@ def _field_value(value: Any, *names: str) -> Any:
     return None
 
 
-def _extract_content_text(content: Any) -> str:
+def _extract_content_text(content: str | list[QwenContentItem] | None) -> str:
     """Extract text from a qwen-agent Message content field.
 
     Content can be a plain string or a list of ContentItem.
@@ -68,7 +78,9 @@ def _extract_content_text(content: Any) -> str:
     return str(content) if content else ""
 
 
-def find_tool_call_id(messages: Any, tool_name: str) -> str | None:
+def find_tool_call_id(
+    messages: list[QwenMessage] | None, tool_name: str
+) -> str | None:
     """Best-effort lookup of the current tool call's function id.
 
     ``FnCallAgent`` passes the message history to ``_call_tool``; the call
@@ -127,7 +139,9 @@ def _tool_call_response_id(msg: Any) -> str:
     return tool_call_id
 
 
-def convert_to_input_messages(messages: Any) -> list[InputMessage]:
+def convert_to_input_messages(
+    messages: QwenMessage | list[QwenMessage] | None,
+) -> list[InputMessage]:
     """Convert a qwen-agent Message list to GenAI InputMessage objects."""
     if not messages:
         return []
@@ -170,7 +184,9 @@ def convert_to_input_messages(messages: Any) -> list[InputMessage]:
     return input_messages
 
 
-def convert_to_output_messages(messages: Any) -> list[OutputMessage]:
+def convert_to_output_messages(
+    messages: QwenMessage | list[QwenMessage] | None,
+) -> list[OutputMessage]:
     """Convert qwen-agent response messages to GenAI OutputMessage objects."""
     if not messages:
         return []
@@ -213,7 +229,9 @@ def convert_to_output_messages(messages: Any) -> list[OutputMessage]:
     return output_messages
 
 
-def convert_to_final_output_messages(messages: Any) -> list[OutputMessage]:
+def convert_to_final_output_messages(
+    messages: QwenMessage | list[QwenMessage] | None,
+) -> list[OutputMessage]:
     """Convert only the final qwen-agent answer to OutputMessage objects.
 
     An agent run yields the full response history including intermediate
@@ -249,7 +267,7 @@ def convert_to_final_output_messages(messages: Any) -> list[OutputMessage]:
 def create_agent_invocation(
     handler: TelemetryHandler,
     agent_instance: Any,
-    messages: Any,
+    messages: QwenMessage | list[QwenMessage] | None,
 ) -> AgentInvocation:
     """Create and start an AgentInvocation for Agent.run()."""
     llm_instance = getattr(agent_instance, "llm", None)

pyproject.toml

@@ -121,6 +121,7 @@ include = [
   "instrumentation/opentelemetry-instrumentation-genai-langchain",
   "instrumentation/opentelemetry-instrumentation-genai-llama-index",
   "instrumentation/opentelemetry-instrumentation-genai-openai-agents",
+  "instrumentation/opentelemetry-instrumentation-genai-qwen-agent",
   "instrumentation/opentelemetry-instrumentation-genai-weaviate-client",
   "util/opentelemetry-util-genai",
 ]
@@ -143,6 +144,8 @@ exclude = [
   "instrumentation/opentelemetry-instrumentation-genai-llama-index/examples/**/*.py",
   "instrumentation/opentelemetry-instrumentation-genai-openai-agents/tests/**/*.py",
   "instrumentation/opentelemetry-instrumentation-genai-openai-agents/examples/**",
+  "instrumentation/opentelemetry-instrumentation-genai-qwen-agent/tests/**/*.py",
+  "instrumentation/opentelemetry-instrumentation-genai-qwen-agent/examples/**/*.py",
   "instrumentation/opentelemetry-instrumentation-genai-weaviate-client/tests/**/*.py",
   "instrumentation/opentelemetry-instrumentation-genai-weaviate-client/examples/**/*.py",
   "util/opentelemetry-util-genai/tests/**/*.py",