Conversation
msimberg
reviewed
Mar 27, 2023
| # ln -s -f ../../tools/pre-commit .git/hooks/pre-commit | ||
| # ---------------------------------------------------------------- | ||
|
|
||
| CLANG_FORMAT_VERSION=clang-format-12 |
Collaborator
There was a problem hiding this comment.
DLAF requires version 10. It might make sense to reuse the scripts that are being used in https://github.com/eth-cscs/DLA-Future/blob/master/.github/workflows/check_format.yml, no?
Collaborator
Author
There was a problem hiding this comment.
ooh. I didn't see that stuff in .github I like the test script - except that it doesn't show the user which files to reformat etc. I will investigate further.
rasolca
marked this pull request as draft
April 11, 2023 12:39
biddisco
marked this pull request as ready for review
December 4, 2023 16:47
Collaborator
Author
|
I have modified the primary .github/format.sh script to allow git precommit use. |
When run as a pre-commit hook, the script will output the names of any badly formatted cpp or cmake files and supply a command line than can be used to fix them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.