Add missing dependent block checks to on_inclusion_list (#5599)

This PR adds missing dependent block's slot and dependent root validity
checks to `on_inclusion_list`.

Author: jihoonsong

specs/gloas/fork-choice.md

@@ -40,6 +40,7 @@
   - [Modified `get_head`](#modified-get_head)
   - [Modified `get_latest_message_epoch`](#modified-get_latest_message_epoch)
   - [New `verify_execution_payload_envelope`](#new-verify_execution_payload_envelope)
+  - [New `is_valid_dependent_root`](#new-is_valid_dependent_root)
   - [Modified `get_attestation_due_ms`](#modified-get_attestation_due_ms)
   - [Modified `get_aggregate_due_ms`](#modified-get_aggregate_due_ms)
   - [Modified `get_sync_message_due_ms`](#modified-get_sync_message_due_ms)
@@ -697,6 +698,24 @@ def verify_execution_payload_envelope(
     )
 ```
 
+### New `is_valid_dependent_root`
+
+```python
+def is_valid_dependent_root(store: Store, root: Root, dependent_slot: Slot) -> bool:
+    """
+    Check if the block with the given ``root`` is a possible dependent block
+    for the given ``dependent_slot``, meaning that on some branch it is, or
+    could become, the latest block at or before ``dependent_slot``.
+    """
+    if root == get_head(store).root:
+        return True
+    for block in store.blocks.values():
+        if block.parent_root == root:
+            if block.slot > dependent_slot:
+                return True
+    return False
+```
+
 ### Modified `get_attestation_due_ms`
 
 ```python

specs/gloas/p2p-interface.md

@@ -26,7 +26,6 @@
   - [New `is_past_slot`](#new-is_past_slot)
   - [New `is_gas_limit_target_compatible`](#new-is_gas_limit_target_compatible)
   - [New `is_bid_compatible_with_head`](#new-is_bid_compatible_with_head)
-  - [New `is_valid_dependent_root`](#new-is_valid_dependent_root)
   - [New `compute_shuffling_dependent_epoch`](#new-compute_shuffling_dependent_epoch)
   - [New `verify_attestation_payload_status`](#new-verify_attestation_payload_status)
   - [New `verify_block_body_operation_limits`](#new-verify_block_body_operation_limits)
@@ -381,25 +380,6 @@ def is_bid_compatible_with_head(store: Store, bid: ExecutionPayloadBid) -> bool:
     return builds_on_parent_payload
 ```
 
-### New `is_valid_dependent_root`
-
-```python
-def is_valid_dependent_root(store: Store, root: Root, epoch: Epoch) -> bool:
-    """
-    Check if the block with the given ``root`` is a possible dependent block
-    for the given ``epoch``, meaning that on some branch it is, or could
-    become, the latest block prior to the start of the epoch.
-    """
-    epoch_start_slot = compute_start_slot_at_epoch(epoch)
-    for block in store.blocks.values():
-        if block.parent_root == root:
-            if block.slot >= epoch_start_slot:
-                return True
-    if root == get_head(store).root:
-        return True
-    return False
-```
-
 ### New `compute_shuffling_dependent_epoch`
 
 ```python
@@ -1132,8 +1112,8 @@ def validate_proposer_preferences_gossip(
     if store.blocks[preferences.dependent_root].slot > dependent_slot:
         raise GossipReject("dependent block is after the shuffling dependent slot")
 
-    # [IGNORE] The dependent block is a possible dependent block for the lookahead epoch
-    if not is_valid_dependent_root(store, preferences.dependent_root, lookahead_epoch):
+    # [IGNORE] The dependent block is a possible dependent block for the proposer lookahead
+    if not is_valid_dependent_root(store, preferences.dependent_root, dependent_slot):
         raise GossipIgnore("dependent block is not a possible dependent block")
 
     # [REJECT] The validator is the proposer for the given slot in the proposer lookahead

specs/heze/fork-choice.md

@@ -281,8 +281,17 @@ def on_inclusion_list(store: Store, signed_inclusion_list: SignedInclusionList)
     assert inclusion_list.slot + MIN_SLOTS_FOR_INCLUSION_LISTS_REQUESTS >= current_slot
 
     # The dependent block must be known
+    assert inclusion_list.dependent_root in store.blocks
     assert inclusion_list.dependent_root in store.block_states
 
+    # The dependent block's slot must not be after the shuffling dependent slot
+    epoch = compute_epoch_at_slot(inclusion_list.slot)
+    dependent_slot = compute_shuffling_dependent_slot(epoch)
+    assert store.blocks[inclusion_list.dependent_root].slot <= dependent_slot
+
+    # The dependent block must be a possible dependent block for the inclusion list committee lookahead
+    assert is_valid_dependent_root(store, inclusion_list.dependent_root, dependent_slot)
+
     # Verify the validator is in the inclusion list committee
     dependent_state = store.block_states[inclusion_list.dependent_root].copy()
     if dependent_state.slot < inclusion_list.slot:

tests/core/pyspec/eth_consensus_specs/test/heze/unittests/inclusion_list/test_inclusion_list_store.py

@@ -192,6 +192,7 @@ def run_func():
             transactions=transactions,
         )
         signed_inclusion_list_0 = sign_inclusion_list(spec, state, inclusion_list_0)
+        spec.on_inclusion_list(forkchoice_store, signed_inclusion_list_0)
 
         # Make a fork branch off the head.
         head_root = spec.get_head(forkchoice_store).root
@@ -219,7 +220,6 @@ def run_func():
 
         # Both inclusion lists are valid, with different dependent roots.
         assert inclusion_list_0.dependent_root != inclusion_list_1.dependent_root
-        spec.on_inclusion_list(forkchoice_store, signed_inclusion_list_0)
         spec.on_inclusion_list(forkchoice_store, signed_inclusion_list_1)
 
         # Only the inclusion list stored under the given dependent root is returned.