Address review feedback on style and the placeholder entry

Apply the review suggestions that need no design discussion: move
`SLOT_DURATION_SCHEDULE` under the existing scheduling section and drop
the extra config comments, remove the no-op `FAR_FUTURE_EPOCH` entry
and the guard that existed only to serve it, annotate the new `slot`
parameter inside the deadline helper signatures, drop the
`field(default_factory=...)` defaults from `Store`, break the
inactivity penalty denominator into named variables, delete the note
about the unchanged blob sidecar retention window, and qualify "era"
as "slot duration era".

Author: barnabemonnot

configs/mainnet.yaml

@@ -64,7 +64,7 @@ HEZE_FORK_EPOCH: 18446744073709551615
 # EIP8321
 EIP8321_FORK_VERSION: 0xe8321000
 EIP8321_FORK_EPOCH: 18446744073709551615
-# EIP8198 (experimental)
+# EIP8198
 EIP8198_FORK_VERSION: 0xe8198000
 EIP8198_FORK_EPOCH: 18446744073709551615
 
@@ -113,7 +113,6 @@ PAYLOAD_ATTESTATION_DUE_BPS: 7500
 # 6667 basis points, ~67% of SLOT_DURATION_MS
 INCLUSION_LIST_DUE_BPS: 6667
 
-
 # Validator cycle
 # ---------------------------------------------------------------
 # 2**2 (= 4)
@@ -240,20 +239,7 @@ BLOB_SCHEDULE:
 
 GAS_LIMIT_SCHEDULE: []
 
-# Slot duration schedule (EIP8198)
-# ---------------------------------------------------------------
-
-SLOT_DURATION_SCHEDULE:
-  - EPOCH: 18446744073709551615  # TBD
-    SLOT_DURATION_MS: 10000
-    PROPOSER_REORG_CUTOFF_MS: 1667
-    ATTESTATION_DUE_MS: 2500
-    AGGREGATE_DUE_MS: 5000
-    SYNC_MESSAGE_DUE_MS: 2500
-    CONTRIBUTION_DUE_MS: 5000
-    PAYLOAD_DUE_MS: 5000
-    PAYLOAD_ATTESTATION_DUE_MS: 7500
-    INCLUSION_LIST_DUE_MS: 6667
+SLOT_DURATION_SCHEDULE: []
 
 # Fast Confirmation Rule
 # ---------------------------------------------------------------

configs/minimal.yaml

@@ -60,7 +60,7 @@ HEZE_FORK_EPOCH: 18446744073709551615
 # [customized] EIP8321
 EIP8321_FORK_VERSION: 0xe8321001
 EIP8321_FORK_EPOCH: 18446744073709551615
-# EIP8198 (experimental)
+# EIP8198
 EIP8198_FORK_VERSION: 0xe8198001
 EIP8198_FORK_EPOCH: 18446744073709551615
 
@@ -109,7 +109,6 @@ PAYLOAD_ATTESTATION_DUE_BPS: 7500
 # 6667 basis points, ~67% of SLOT_DURATION_MS
 INCLUSION_LIST_DUE_BPS: 6667
 
-
 # Validator cycle
 # ---------------------------------------------------------------
 # 2**2 (= 4)
@@ -233,20 +232,7 @@ BLOB_SCHEDULE: []
 
 GAS_LIMIT_SCHEDULE: []
 
-# Slot duration schedule (EIP8198)
-# ---------------------------------------------------------------
-
-SLOT_DURATION_SCHEDULE:
-  - EPOCH: 18446744073709551615  # TBD
-    SLOT_DURATION_MS: 5000  # [customized]
-    PROPOSER_REORG_CUTOFF_MS: 833
-    ATTESTATION_DUE_MS: 1250
-    AGGREGATE_DUE_MS: 2500
-    SYNC_MESSAGE_DUE_MS: 1250
-    CONTRIBUTION_DUE_MS: 2500
-    PAYLOAD_DUE_MS: 2500
-    PAYLOAD_ATTESTATION_DUE_MS: 3750
-    INCLUSION_LIST_DUE_MS: 3333
+SLOT_DURATION_SCHEDULE: []
 
 # Fast Confirmation Rule
 # ---------------------------------------------------------------

specs/_features/eip8198/beacon-chain.md

@@ -30,13 +30,13 @@
 EIP-8198 ("Quick Slots") makes the slot duration schedulable, with a first
 reduction from 12 to 10 seconds intended at the fork epoch. The slot structure
 is unchanged, and each schedule entry carries the intra-slot deadlines of its
-era as explicit millisecond values, so they can be adjusted whenever the slot
-duration changes. The remaining duration-dependent parameters are rescaled by
-the ratio `r = get_slot_duration_ms(epoch) / SLOT_DURATION_MS` to keep their
-wall-clock behavior constant: issuance and churn are per-epoch rates and scale
-by `r`, while the inactivity penalty scales by `r**2` so that the cumulative
-leak over a fixed wall-clock duration is unchanged. Each formula applies the
-ratio inline rather than pre-computing rounded constants. Epoch- and
+slot duration era as explicit millisecond values, so they can be adjusted
+whenever the slot duration changes. The remaining duration-dependent parameters
+are rescaled by the ratio `r = get_slot_duration_ms(epoch) / SLOT_DURATION_MS`
+to keep their wall-clock behavior constant: issuance and churn are per-epoch
+rates and scale by `r`, while the inactivity penalty scales by `r**2` so that
+the cumulative leak over a fixed wall-clock duration is unchanged. Each formula
+applies the ratio inline rather than pre-computing rounded constants. Epoch- and
 slot-denominated quantities — withdrawability and slashing windows, sync
 committee periods, per-payload and per-epoch processing limits — keep their
 counts, so their wall-clock spans scale with the slot duration.
@@ -53,8 +53,7 @@ deadlines for a given epoch. Epochs before the first entry use
 
 There MUST NOT exist multiple slot duration schedule entries with the same epoch
 value. The epoch value in each entry MUST be greater than or equal to
-`EIP8198_FORK_EPOCH`; an entry with an epoch of `FAR_FUTURE_EPOCH` is not
-scheduled and has no effect. The slot duration in each entry MUST be a positive
+`EIP8198_FORK_EPOCH`. The slot duration in each entry MUST be a positive
 multiple of `1000`, so that every slot boundary has an exact integer-second
 timestamp. Every deadline in an entry MUST be positive and less than the entry's
 slot duration, and the deadlines MUST preserve the inherited ordering: the
@@ -67,14 +66,14 @@ MUST be accompanied by a `BLOB_SCHEDULE` entry at the same epoch that scales the
 maximum blobs per block by the slot-duration ratio (rounding down), keeping blob
 throughput per unit time constant.
 
-The epoch of the mainnet entry below is **TBD** and is intended to be the fork
+The schedule is empty until the epoch of the first slot duration change is
+decided; the intended mainnet entry is a 10-second slot duration at the fork
 epoch.
 
 <!-- list-of-records:slot_duration_schedule -->
 
-|                Epoch | Slot Duration Ms | Proposer Reorg Cutoff Ms | Attestation Due Ms | Aggregate Due Ms | Sync Message Due Ms | Contribution Due Ms | Payload Due Ms | Payload Attestation Due Ms | Inclusion List Due Ms | Description |
-| -------------------: | ---------------: | -----------------------: | -----------------: | ---------------: | ------------------: | ------------------: | -------------: | -------------------------: | --------------------: | ----------- |
-| 18446744073709551615 |            10000 |                     1667 |               2500 |             5000 |                2500 |                5000 |           5000 |                       7500 |                  6667 | 10 seconds  |
+| Epoch | Slot Duration Ms | Proposer Reorg Cutoff Ms | Attestation Due Ms | Aggregate Due Ms | Sync Message Due Ms | Contribution Due Ms | Payload Due Ms | Payload Attestation Due Ms | Inclusion List Due Ms | Description |
+| ----: | ---------------: | -----------------------: | -----------------: | ---------------: | ------------------: | ------------------: | -------------: | -------------------------: | --------------------: | ----------- |
 
 ## Helpers
 
@@ -104,7 +103,7 @@ def get_slot_timing_parameters(epoch: Epoch) -> SlotTimingParameters:
     Return the slot timing parameters in effect at ``epoch``.
     """
     for entry in sorted(SLOT_DURATION_SCHEDULE, key=lambda entry: entry["EPOCH"], reverse=True):
-        if entry["EPOCH"] != FAR_FUTURE_EPOCH and epoch >= entry["EPOCH"]:
+        if epoch >= entry["EPOCH"]:
             return SlotTimingParameters(
                 slot_duration_ms=entry["SLOT_DURATION_MS"],
                 proposer_reorg_cutoff_ms=entry["PROPOSER_REORG_CUTOFF_MS"],
@@ -150,8 +149,6 @@ def compute_slot_start_time_ms(genesis_time: Uint64, slot: Slot) -> Uint64:
     era_start_slot = GENESIS_SLOT
     era_duration_ms = SLOT_DURATION_MS
     for entry in sorted(SLOT_DURATION_SCHEDULE, key=lambda entry: entry["EPOCH"]):
-        if entry["EPOCH"] == FAR_FUTURE_EPOCH:
-            break
         entry_slot = compute_start_slot_at_epoch(entry["EPOCH"])
         if slot < entry_slot:
             break
@@ -173,8 +170,6 @@ def compute_slot_at_time_ms(genesis_time: Uint64, time_ms: Uint64) -> Slot:
     era_start_slot = GENESIS_SLOT
     era_duration_ms = SLOT_DURATION_MS
     for entry in sorted(SLOT_DURATION_SCHEDULE, key=lambda entry: entry["EPOCH"]):
-        if entry["EPOCH"] == FAR_FUTURE_EPOCH:
-            break
         entry_slot = compute_start_slot_at_epoch(entry["EPOCH"])
         era_length_ms = (entry_slot - era_start_slot) * era_duration_ms
         if remaining_ms < era_length_ms:
@@ -253,13 +248,10 @@ def get_inactivity_penalty_deltas(state: BeaconState) -> Tuple[Sequence[Gwei], S
             )
             # [Modified in EIP8198]
             slot_duration_ms = get_slot_duration_ms(get_current_epoch(state))
-            penalty_denominator = (
-                INACTIVITY_SCORE_BIAS
-                * INACTIVITY_PENALTY_QUOTIENT_BELLATRIX
-                * SLOT_DURATION_MS
-                * SLOT_DURATION_MS
-                // (slot_duration_ms * slot_duration_ms)
-            )
+            duration_squared = slot_duration_ms * slot_duration_ms
+            base_duration_squared = SLOT_DURATION_MS * SLOT_DURATION_MS
+            penalty_quotient = INACTIVITY_SCORE_BIAS * INACTIVITY_PENALTY_QUOTIENT_BELLATRIX
+            penalty_denominator = penalty_quotient * base_duration_squared // duration_squared
             penalties[index] += Gwei(penalty_numerator // penalty_denominator)
     return rewards, penalties
 ```

specs/_features/eip8198/fork-choice.md

@@ -39,7 +39,7 @@ EIP-8198 makes the slot duration change per `SLOT_DURATION_SCHEDULE`. Intra-slot
 deadlines are read from the schedule entry in effect at a duty's slot, so the
 deadline helpers gain a `slot` parameter; the inherited basis-point deadlines
 apply before the first schedule entry. The mapping between wall-clock time and
-slot number becomes piecewise over the schedule's eras, and every timeliness
+slot number becomes piecewise over the slot duration eras, and every timeliness
 check is rebased on the new `get_time_into_slot_ms` helper. The store clock
 gains millisecond precision: implementations MUST drive the store with
 `on_tick_ms`; the whole-second `on_tick` remains only as a compatibility
@@ -67,18 +67,16 @@ class Store:
     unrealized_finalized_checkpoint: Checkpoint
     proposer_boost_root: Root
     equivocating_indices: Set[ValidatorIndex]
-    blocks: Dict[Root, BeaconBlock] = field(default_factory=dict)
-    block_states: Dict[Root, BeaconState] = field(default_factory=dict)
-    block_timeliness: Dict[Root, list[bool]] = field(default_factory=dict)
-    checkpoint_states: Dict[Checkpoint, BeaconState] = field(default_factory=dict)
-    latest_messages: Dict[ValidatorIndex, LatestMessage] = field(default_factory=dict)
-    unrealized_justifications: Dict[Root, Checkpoint] = field(default_factory=dict)
-    payloads: Dict[Root, ExecutionPayloadEnvelope] = field(default_factory=dict)
-    payload_timeliness_vote: Dict[Root, list[Optional[Boolean]]] = field(default_factory=dict)
-    payload_data_availability_vote: Dict[Root, list[Optional[Boolean]]] = field(
-        default_factory=dict
-    )
-    payload_inclusion_list_satisfaction: Dict[Root, bool] = field(default_factory=dict)
+    blocks: Dict[Root, BeaconBlock]
+    block_states: Dict[Root, BeaconState]
+    block_timeliness: Dict[Root, list[bool]]
+    checkpoint_states: Dict[Checkpoint, BeaconState]
+    latest_messages: Dict[ValidatorIndex, LatestMessage]
+    unrealized_justifications: Dict[Root, Checkpoint]
+    payloads: Dict[Root, ExecutionPayloadEnvelope]
+    payload_timeliness_vote: Dict[Root, list[Optional[Boolean]]]
+    payload_data_availability_vote: Dict[Root, list[Optional[Boolean]]]
+    payload_inclusion_list_satisfaction: Dict[Root, bool]
 ```
 
 ### Modified `get_forkchoice_store`
@@ -111,6 +109,7 @@ def get_forkchoice_store(anchor_state: BeaconState, anchor_block: BeaconBlock) -
         block_states={anchor_root: copy(anchor_state)},
         block_timeliness={anchor_root: [True, True]},
         checkpoint_states={justified_checkpoint: copy(anchor_state)},
+        latest_messages={},
         unrealized_justifications={anchor_root: justified_checkpoint},
         payloads={},
         payload_timeliness_vote={anchor_root: [None] * PTC_SIZE},
@@ -166,72 +165,80 @@ since the deadline of a duty is read from the schedule entry in effect at its
 slot.
 
 ```python
-def get_attestation_due_ms(slot: Slot) -> Uint64:
-    # [Modified in EIP8198]
-    # Added `slot`
+def get_attestation_due_ms(
+    # [New in EIP8198]
+    slot: Slot,
+) -> Uint64:
     return get_slot_timing_parameters(compute_epoch_at_slot(slot)).attestation_due_ms
 ```
 
 ### Modified `get_proposer_reorg_cutoff_ms`
 
 ```python
-def get_proposer_reorg_cutoff_ms(slot: Slot) -> Uint64:
-    # [Modified in EIP8198]
-    # Added `slot`
+def get_proposer_reorg_cutoff_ms(
+    # [New in EIP8198]
+    slot: Slot,
+) -> Uint64:
     return get_slot_timing_parameters(compute_epoch_at_slot(slot)).proposer_reorg_cutoff_ms
 ```
 
 ### Modified `get_aggregate_due_ms`
 
 ```python
-def get_aggregate_due_ms(slot: Slot) -> Uint64:
-    # [Modified in EIP8198]
-    # Added `slot`
+def get_aggregate_due_ms(
+    # [New in EIP8198]
+    slot: Slot,
+) -> Uint64:
     return get_slot_timing_parameters(compute_epoch_at_slot(slot)).aggregate_due_ms
 ```
 
 ### Modified `get_sync_message_due_ms`
 
 ```python
-def get_sync_message_due_ms(slot: Slot) -> Uint64:
-    # [Modified in EIP8198]
-    # Added `slot`
+def get_sync_message_due_ms(
+    # [New in EIP8198]
+    slot: Slot,
+) -> Uint64:
     return get_slot_timing_parameters(compute_epoch_at_slot(slot)).sync_message_due_ms
 ```
 
 ### Modified `get_contribution_due_ms`
 
 ```python
-def get_contribution_due_ms(slot: Slot) -> Uint64:
-    # [Modified in EIP8198]
-    # Added `slot`
+def get_contribution_due_ms(
+    # [New in EIP8198]
+    slot: Slot,
+) -> Uint64:
     return get_slot_timing_parameters(compute_epoch_at_slot(slot)).contribution_due_ms
 ```
 
 ### Modified `get_payload_due_ms`
 
 ```python
-def get_payload_due_ms(slot: Slot) -> Uint64:
-    # [Modified in EIP8198]
-    # Added `slot`
+def get_payload_due_ms(
+    # [New in EIP8198]
+    slot: Slot,
+) -> Uint64:
     return get_slot_timing_parameters(compute_epoch_at_slot(slot)).payload_due_ms
 ```
 
 ### Modified `get_payload_attestation_due_ms`
 
 ```python
-def get_payload_attestation_due_ms(slot: Slot) -> Uint64:
-    # [Modified in EIP8198]
-    # Added `slot`
+def get_payload_attestation_due_ms(
+    # [New in EIP8198]
+    slot: Slot,
+) -> Uint64:
     return get_slot_timing_parameters(compute_epoch_at_slot(slot)).payload_attestation_due_ms
 ```
 
 ### Modified `get_inclusion_list_due_ms`
 
 ```python
-def get_inclusion_list_due_ms(slot: Slot) -> Uint64:
-    # [Modified in EIP8198]
-    # Added `slot`
+def get_inclusion_list_due_ms(
+    # [New in EIP8198]
+    slot: Slot,
+) -> Uint64:
     return get_slot_timing_parameters(compute_epoch_at_slot(slot)).inclusion_list_due_ms
 ```
 

specs/_features/eip8198/p2p-interface.md

@@ -167,10 +167,7 @@ Request and response message types are unchanged from Heze. In the inherited
 data-column sidecar request validations and pruning guidance,
 `get_data_column_sidecars_retention_start(current_epoch)` replaces the rolling
 `current_epoch - MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS` term; the
-inherited `FULU_FORK_EPOCH` floor is unchanged. The blob sidecar Req/Resp
-messages are already deprecated as of
-`FULU_FORK_EPOCH + MIN_EPOCHS_FOR_BLOB_SIDECARS_REQUESTS`, so their retention
-window needs no treatment.
+inherited `FULU_FORK_EPOCH` floor is unchanged.
 
 Epoch-denominated retention windows without a wall-clock target — in particular
 the block retention window `compute_min_epochs_for_block_requests()` — keep

tests/core/pyspec/eth_consensus_specs/test/eip8198/unittests/test_slot_duration.py

@@ -507,12 +507,8 @@ def test_retention_window_preserves_wall_clock_length(spec, state):
 @with_phases([EIP8198])
 @spec_test
 @single_phase
-def test_unscheduled_entry_has_no_effect(spec):
-    # The default schedule only contains the placeholder entry at
-    # FAR_FUTURE_EPOCH, which must behave as if the schedule were empty.
-    for entry in spec.config.SLOT_DURATION_SCHEDULE:
-        assert entry["EPOCH"] == spec.FAR_FUTURE_EPOCH
-    assert spec.get_slot_duration_ms(spec.FAR_FUTURE_EPOCH) == spec.config.SLOT_DURATION_MS
+def test_empty_schedule_keeps_base_duration(spec):
+    assert spec.config.SLOT_DURATION_SCHEDULE == ()
     for epoch in (spec.GENESIS_EPOCH, spec.Epoch(8192), spec.Epoch(100_000)):
         assert spec.get_slot_duration_ms(epoch) == spec.config.SLOT_DURATION_MS
         slot = spec.compute_start_slot_at_epoch(epoch)