Pass only signed bid to process_execution_payload_bid - #5364
Merged
Conversation
Most operation processors take the minimum amount of information that's needed for validation, e.g., process_sync_aggregate solely takes the sync aggregate. For process_execution_payload_bid, the full block is passed instead, while at the same time requiring in validator.md that the verification checks in process_execution_payload_bid have to be run in order to construct a bid. Clean that up by only taking the SignedExecutionPayloadBid, so that the verification checks no longer depend on the existence of a BeaconBlock.
jtraglia
reviewed
Jun 15, 2026
jtraglia
changed the title
process_execution_payload_bid
Member
|
Forgot to approve this first. LGTM, thanks @etan-status. |
jtraglia
added a commit
that referenced
this pull request
Jun 17, 2026
Related to: * #5364 * #5365 I merged these back-to-back without pulling in updates from master & didn't realize that they conflicted. The first removes block as a parameter which the second uses to get the proposer index. Thankfully, the fix is simple; we can use `get_beacon_proposer_index` for this. It's worth mentioning that `process_block_header` checks that these are the same, so this change is safe.
nflaig
added a commit
to ChainSafe/lodestar
that referenced
this pull request
Jun 21, 2026
ensi321
added a commit
to ChainSafe/lodestar
that referenced
this pull request
Jun 26, 2026
implements the following spec changes required to pass `v1.7.0-alpha.11` spec tests - ethereum/consensus-specs#5359 - ethereum/consensus-specs#5377 - ethereum/consensus-specs#5373 - ethereum/consensus-specs#5365 - ethereum/consensus-specs#5364 - ethereum/consensus-specs#5368 --------- Co-authored-by: NC <17676176+ensi321@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most operation processors take the minimum amount of information that's needed for validation, e.g., process_sync_aggregate solely takes the sync aggregate. For process_execution_payload_bid, the full block is passed instead, while at the same time requiring in validator.md that the verification checks in process_execution_payload_bid have to be run in order to construct a bid.
Clean that up by only taking the SignedExecutionPayloadBid, so that the verification checks no longer depend on the existence of a BeaconBlock.