Skip to content

Align note comments to use complete sentences - #5375

Merged
jihoonsong merged 1 commit into
ethereum:masterfrom
jihoonsong:execution-engine-notes
Jun 19, 2026
Merged

Align note comments to use complete sentences#5375
jihoonsong merged 1 commit into
ethereum:masterfrom
jihoonsong:execution-engine-notes

Conversation

@jihoonsong

Copy link
Copy Markdown
Member

I'm not entirely sure about note comments that we currently have in general, but this PR makes it a bit more consistent at least.

Comment thread specs/capella/fork-choice.md Outdated
@jihoonsong
jihoonsong force-pushed the execution-engine-notes branch from 55f8907 to 8e0c230 Compare June 19, 2026 08:32
@jihoonsong jihoonsong changed the title Align note comments in ExecutionEngine sections Align note comments to use complete sentences Jun 19, 2026
@jihoonsong
jihoonsong force-pushed the execution-engine-notes branch from 8e0c230 to 0a0ec36 Compare June 19, 2026 08:43
@github-actions github-actions Bot added the deneb label Jun 19, 2026
@jihoonsong
jihoonsong force-pushed the execution-engine-notes branch 2 times, most recently from f3e22d3 to ca668a4 Compare June 19, 2026 08:50
@jihoonsong
jihoonsong force-pushed the execution-engine-notes branch from ca668a4 to aff3e1a Compare June 19, 2026 08:51

@jtraglia jtraglia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jihoonsong
jihoonsong enabled auto-merge (squash) June 19, 2026 08:55
@jihoonsong
jihoonsong disabled auto-merge June 19, 2026 08:55
@jihoonsong
jihoonsong enabled auto-merge (squash) June 19, 2026 08:55
@jihoonsong
jihoonsong merged commit a8fc06a into ethereum:master Jun 19, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants