Remove unnecessary casts - #5588
Merged
Merged
Conversation
jihoonsong
reviewed
Sep 2, 2026
jihoonsong
left a comment
jihoonsong
left a comment
Member
There was a problem hiding this comment.
This is nice. Can we also remove Epoch(1) and Slot(1) type casts? There are some more of these.
Member
Author
|
Thanks @jihoonsong. Fixed those too. This might not be exhaustive, but it's a step in the right direction. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we're using
eth-ssz-specsandty, we can remove a lot of these unnecessary type casts. This is because ineth-ssz-specs, operations return the expected type. I believe this helps readability a lot, because it's simpler.