Check the voluntary exit epoch against the wall clock - #5596
Merged
Conversation
The voluntary exit epoch was compared against the head state's current epoch, which lags the wall clock and ignores clock disparity, so an exit published at the start of its epoch could be dropped by peers whose head has not advanced yet. Add `is_future_epoch`, which derives the current epoch from the wall clock with a `MAXIMUM_GOSSIP_CLOCK_DISPARITY` allowance, and use it in place of that comparison. The check no longer needs the state, so it moves ahead of the head lookup where it is much cheaper.
jihoonsong
reviewed
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
validate_voluntary_exit_gossip, the voluntary exit epoch was compared against the head state's current epoch, which lags the wall clock and ignores clock disparity, so an exit published at the start of its epoch could be dropped by peers whose head has not advanced yet. This PR addsis_future_epoch, which derives the current epoch from the wall clock with aMAXIMUM_GOSSIP_CLOCK_DISPARITYallowance, and use it in place of that comparison. The check no longer needs the state, so it moves ahead of the head lookup where it is much cheaper.