fix(transaction): improve gas estimation reliability and error handling (#5344)

Author: gacevicljubisa

cmd/bee/cmd/cmd.go

@@ -82,6 +82,7 @@ const (
 	optionReserveCapacityDoubling          = "reserve-capacity-doubling"
 	optionSkipPostageSnapshot              = "skip-postage-snapshot"
 	optionNameMinimumGasTipCap             = "minimum-gas-tip-cap"
+	optionNameGasLimitFallback             = "gas-limit-fallback"
 	optionNameP2PWSSEnable                 = "p2p-wss-enable"
 	optionP2PWSSAddr                       = "p2p-wss-addr"
 	optionNATWSSAddr                       = "nat-wss-addr"
@@ -297,6 +298,7 @@ func (c *command) setAllFlags(cmd *cobra.Command) {
 	cmd.Flags().Int(optionReserveCapacityDoubling, 0, "reserve capacity doubling")
 	cmd.Flags().Bool(optionSkipPostageSnapshot, false, "skip postage snapshot")
 	cmd.Flags().Uint64(optionNameMinimumGasTipCap, 0, "minimum gas tip cap in wei for transactions, 0 means use suggested gas tip cap")
+	cmd.Flags().Uint64(optionNameGasLimitFallback, 500_000, "gas limit fallback when estimation fails for contract transactions")
 	cmd.Flags().Bool(optionNameP2PWSSEnable, false, "Enable Secure WebSocket P2P connections")
 	cmd.Flags().String(optionP2PWSSAddr, ":1635", "p2p wss address")
 	cmd.Flags().String(optionNATWSSAddr, "", "WSS NAT exposed address")

cmd/bee/cmd/deploy.go

@@ -60,6 +60,7 @@ func (c *command) initDeployCmd() error {
 				blocktime,
 				true,
 				c.config.GetUint64(optionNameMinimumGasTipCap),
+				c.config.GetUint64(optionNameGasLimitFallback),
 			)
 			if err != nil {
 				return err

cmd/bee/cmd/start.go

@@ -303,6 +303,7 @@ func buildBeeNode(ctx context.Context, c *command, cmd *cobra.Command, logger lo
 		FullNodeMode:                  fullNode,
 		Logger:                        logger,
 		MinimumGasTipCap:              c.config.GetUint64(optionNameMinimumGasTipCap),
+		GasLimitFallback:              c.config.GetUint64(optionNameGasLimitFallback),
 		MinimumStorageRadius:          c.config.GetUint(optionMinimumStorageRadius),
 		MutexProfile:                  c.config.GetBool(optionNamePProfMutex),
 		NATAddr:                       c.config.GetString(optionNameNATAddr),

packaging/bee.yaml

@@ -108,6 +108,8 @@ password-file: "/var/lib/bee/password"
 # tracing-port: ""
 ## service name identifier for tracing
 # tracing-service-name: bee
+## gas limit fallback when estimation fails for contract transactions (default 500000)
+# gas-limit-fallback: 500000
 ## skips the gas estimate step for contract transactions
 # transaction-debug-mode: false
 ## log verbosity level 0=silent, 1=error, 2=warn, 3=info, 4=debug, 5=trace

packaging/docker/docker-compose.yml

@@ -39,6 +39,7 @@ services:
       - BEE_TRACING_ENABLE
       - BEE_TRACING_ENDPOINT
       - BEE_TRACING_SERVICE_NAME
+      - BEE_GAS_LIMIT_FALLBACK
       - BEE_TRANSACTION
       - BEE_VERBOSITY
       - BEE_WELCOME_MESSAGE

packaging/docker/env

@@ -119,6 +119,8 @@
 # BEE_TRACING_PORT=
 ## service name identifier for tracing
 # BEE_TRACING_SERVICE_NAME=
+## gas limit fallback when estimation fails for contract transactions (default 500000)
+# BEE_GAS_LIMIT_FALLBACK=500000
 ## skips the gas estimate step for contract transactions
 # BEE_TRANSACTION_DEBUG_MODE=false
 ## bootstrap node using postage snapshot from the network

packaging/homebrew-amd64/bee.yaml

@@ -108,6 +108,8 @@ password-file: "/usr/local/var/lib/swarm-bee/password"
 # tracing-port: ""
 ## service name identifier for tracing
 # tracing-service-name: bee
+## gas limit fallback when estimation fails for contract transactions (default 500000)
+# gas-limit-fallback: 500000
 ## skips the gas estimate step for contract transactions
 # transaction-debug-mode: false
 ## log verbosity level 0=silent, 1=error, 2=warn, 3=info, 4=debug, 5=trace

packaging/homebrew-arm64/bee.yaml

@@ -108,6 +108,8 @@ password-file: "/opt/homebrew/var/lib/swarm-bee/password"
 # tracing-port: ""
 ## service name identifier for tracing
 # tracing-service-name: bee
+## gas limit fallback when estimation fails for contract transactions (default 500000)
+# gas-limit-fallback: 500000
 ## skips the gas estimate step for contract transactions
 # transaction-debug-mode: false
 ## log verbosity level 0=silent, 1=error, 2=warn, 3=info, 4=debug, 5=trace

packaging/scoop/bee.yaml

@@ -108,6 +108,8 @@ password-file: "./password"
 # tracing-port: ""
 ## service name identifier for tracing
 # tracing-service-name: bee
+## gas limit fallback when estimation fails for contract transactions (default 500000)
+# gas-limit-fallback: 500000
 ## skips the gas estimate step for contract transactions
 # transaction-debug-mode: false
 ## log verbosity level 0=silent, 1=error, 2=warn, 3=info, 4=debug, 5=trace

pkg/node/chain.go

@@ -51,6 +51,7 @@ func InitChain(
 	pollingInterval time.Duration,
 	chainEnabled bool,
 	minimumGasTipCap uint64,
+	fallbackGasLimit uint64,
 ) (transaction.Backend, common.Address, int64, transaction.Monitor, transaction.Service, error) {
 	backend := backendnoop.New(chainID)
 
@@ -91,7 +92,7 @@ func InitChain(
 
 	transactionMonitor := transaction.NewMonitor(logger, backend, overlayEthAddress, pollingInterval, cancellationDepth)
 
-	transactionService, err := transaction.NewService(logger, overlayEthAddress, backend, signer, stateStore, backendChainID, transactionMonitor)
+	transactionService, err := transaction.NewService(logger, overlayEthAddress, backend, signer, stateStore, backendChainID, transactionMonitor, fallbackGasLimit)
 	if err != nil {
 		return nil, common.Address{}, 0, nil, nil, fmt.Errorf("transaction service: %w", err)
 	}