fix(cmd): reject storage incentives in light and ultra-light modes

Author: martinconic

cmd/bee/cmd/resolve_node_mode_test.go

@@ -92,6 +92,15 @@ func TestResolveNodeMode(t *testing.T) {
 			},
 			wantErr: "light node requires blockchain-rpc-endpoint",
 		},
+		{
+			name: "light mode rejects storage-incentives-enable",
+			config: map[string]any{
+				optionNameNodeMode:                "light",
+				configKeyBlockchainRpcEndpoint:    "http://localhost:8545",
+				optionNameStorageIncentivesEnable: true,
+			},
+			wantErr: "light node cannot have storage-incentives-enable",
+		},
 		{
 			name: "ultra-light mode succeeds",
 			config: map[string]any{
@@ -107,6 +116,14 @@ func TestResolveNodeMode(t *testing.T) {
 			},
 			wantErr: "ultra-light node cannot have swap-enable",
 		},
+		{
+			name: "ultra-light mode rejects storage-incentives-enable",
+			config: map[string]any{
+				optionNameNodeMode:                "ultra-light",
+				optionNameStorageIncentivesEnable: true,
+			},
+			wantErr: "ultra-light node cannot have storage-incentives-enable",
+		},
 		{
 			name: "invalid node-mode value fails",
 			config: map[string]any{

cmd/bee/cmd/start.go

@@ -451,10 +451,16 @@ func (c *command) resolveNodeMode(logger log.Logger) (node.NodeMode, error) {
 			if rpcEndpoint == "" {
 				return "", errors.New("light node requires blockchain-rpc-endpoint to be set")
 			}
+			if incentivesEnable {
+				return "", errors.New("light node cannot have storage-incentives-enable set to true")
+			}
 		case node.UltraLightMode:
 			if swapEnable {
 				return "", errors.New("ultra-light node cannot have swap-enable set to true")
 			}
+			if incentivesEnable {
+				return "", errors.New("ultra-light node cannot have storage-incentives-enable set to true")
+			}
 		}
 		return mode, nil
 	}