feat: bootup time metrics - #5162
Merged
Merged
Conversation
gacevicljubisa
self-requested a review
July 24, 2025 10:38
| return | ||
| case <-syncCheckTicker.C: | ||
| synced := isFullySynced() | ||
| logger.Debug("sync status check", "synced", synced, "reserveSize", localStore.ReserveSize(), "threshold", reserveTreshold, "syncRate", pullerService.SyncRate()) |
Member
There was a problem hiding this comment.
Maybe change log level to Trace, because it will spam every second until ReserveSize reaches trashold? Or we can even increase the time checking to 2 seconds?
Member
Author
There was a problem hiding this comment.
I increased the time check to 2 seconds because debug level is the most verbose.
nugaon
marked this pull request as ready for review
August 13, 2025 08:02
martinconic
reviewed
Aug 13, 2025
| wg sync.WaitGroup | ||
| totaldur float64 | ||
| peers []peer | ||
| neighborhoodPeers []peer |
Contributor
There was a problem hiding this comment.
As I see this is more like a counter, why slice of peer ?
gacevicljubisa
approved these changes
Aug 18, 2025
martinconic
approved these changes
Aug 20, 2025
sbackend123
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bee Network Metrics Enhancement Session Summary
Code Changes and Investigations
Neighborhood Metrics Implementation
enhanced the Salud package with new metrics to better track neighborhood-specific performance:
NeighborhoodAvgDur: Tracks average response duration specifically for neighborhood peersNeighborCount: Tracks the count of neighborhood peersNode Spinup Metrics:
Defined node metrics in pkg/node/metrics.go:
WarmupDuration: Histogram measuring time for node warmup to completeFullSyncDuration: Histogram measuring time for full sync to completeImplemented metrics collection in pkg/node/node.go:
Grafana Visualization Proposal
Below is a Grafana dashboard design to visualize the newly introduced metrics:
Node Spinup Performance Dashboard
bee_init_warmup_duration_secondsbee_salud_neighborsbee_salud_neighborhood_durbee_storer_reserve_size_within_radiusChecklist
Description
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):