fix(p2p): add tcp share when ws enabled - #5314
Closed
acud wants to merge 1 commit into
Closed
Conversation
Member
|
Hi Elad, we have experimented with ShareTCPListener option and had some connectivity issues with it. As we need WSS, we have left ShareTCPListener for WS to address after WSS is implemented as that is actually needed for in-browser node. Plain text WS is not possible to work from browser, so it is deprioritized. It requires investigations on testnet in order to debug. |
martinconic
reviewed
Jan 9, 2026
| transports = append(transports, libp2p.Transport(ws.New, wsOpt)) | ||
| } else if o.EnableWS { | ||
| transports = append(transports, libp2p.Transport(ws.New)) | ||
| opts = append(opts, libp2p.ShareTCPListener()) |
Contributor
There was a problem hiding this comment.
We extensively tested this setting a few months ago and ran into several issues. While our recent libp2p updates might have resolved those problems, I’d recommend holding off on merging this into autotls-v2 for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
libp2p needs a specific option added to the constructor when trying to reuse the existing TCP port listener both for normal TCP connections and for incoming WS connections. Since this is exactly what is done in bee (there is no separate port listener for WS connections), we must include this option when the WS transport is enabled.