fix(p2p): use connection remote addr as fallback when peerstore is empty - #5336
Merged
Conversation
gacevicljubisa
requested review from
acud,
akrem-chabchoub,
janos and
martinconic
January 29, 2026 08:59
| handshakeStream := newStream(stream, s.metrics) | ||
|
|
||
| peerMultiaddrs, err := s.peerMultiaddrs(s.ctx, peerID) | ||
| peerMultiaddrs, err := s.peerMultiaddrs(s.ctx, stream.Conn().RemoteMultiaddr(), peerID) |
Contributor
There was a problem hiding this comment.
Is it always guaranteed that the stream.Conn() is not nil here ?
Member
Author
There was a problem hiding this comment.
stream is always associated with a valid network.Conn, so this shouldn't happen
akrem-chabchoub
approved these changes
Jan 29, 2026
martinconic
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Fixes a backwards-compatibility bug affecting local nodes running v2.6.0 behind NAT without port forwarding.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):