refactor(libp2p): rename underlays to overlayToPeerID in peer registry - #5337
Merged
gacevicljubisa merged 1 commit intoJan 29, 2026
Merged
Conversation
gacevicljubisa
requested review from
acud,
akrem-chabchoub,
janos and
martinconic
January 29, 2026 10:47
gacevicljubisa
changed the title
janos
approved these changes
Jan 29, 2026
akrem-chabchoub
approved these changes
Jan 29, 2026
gacevicljubisa
deleted the
refactor/peer-registry-underlays-to-peer-ids
branch
January 29, 2026 12:07
v1rtl
added a commit
to v1rtl/bee
that referenced
this pull request
Jun 2, 2026
Relax the non-empty underlay validation in bzz.ParseAddress/MarshalJSON so browser/wasm and strict-NAT peers that cannot be dialed back can still handshake and use protocols over existing connections. Guard the Connect addressbook.Put so such peers are not stored for reconnection (v2.8 already guards handleIncoming and the reacher). Port of pr-5326; peer registry rename already landed upstream via ethersphere#5337. Note: this is a deliberate protocol relaxation vs upstream v2.8.
v1rtl
added a commit
to v1rtl/bee
that referenced
this pull request
Jun 2, 2026
Relax the non-empty underlay validation in bzz.ParseAddress/MarshalJSON so browser/wasm and strict-NAT peers that cannot be dialed back can still handshake and use protocols over existing connections. Guard the Connect addressbook.Put so such peers are not stored for reconnection (v2.8 already guards handleIncoming and the reacher). Port of pr-5326; peer registry rename already landed upstream via ethersphere#5337. Note: this is a deliberate protocol relaxation vs upstream v2.8.
v1rtl
added a commit
to v1rtl/bee
that referenced
this pull request
Aug 10, 2026
Relax the non-empty underlay validation in bzz.ParseAddress/MarshalJSON so browser/wasm and strict-NAT peers that cannot be dialed back can still handshake and use protocols over existing connections. Guard the Connect addressbook.Put so such peers are not stored for reconnection (v2.8 already guards handleIncoming and the reacher). Port of pr-5326; peer registry rename already landed upstream via ethersphere#5337. Note: this is a deliberate protocol relaxation vs upstream v2.8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
The field 'underlays' was misleadingly named as it:
Renamed to 'overlayToPeerID' to accurately reflect that it maps
overlay addresses (string) to their corresponding libp2p peer IDs.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):