fix(addressbook): lock remove - #5573
Merged
Merged
Conversation
acud
approved these changes
Aug 24, 2026
martinconic
approved these changes
Aug 24, 2026
Contributor
|
Please add a description |
akrem-chabchoub
requested review from
aloknerurkar,
gacevicljubisa and
sbackend123
August 28, 2026 11:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Removedeleted an addressbook entry without holding the lock thatPutandSeenboth use. This let a concurrent Seen call read the entry, haveRemovedelete it in between, then write its stale copy back, silently undoing the removal.In practice: kademlia calls
Removewhen it evicts a bad peer, but a concurrent hive gossip sighting or kademlia's periodic "seen" sweep on the same peer could bring it right back.Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
AI Disclosure