test(redis): stop assuming equal-stake winner - #321
Merged
Conversation
Equal-stake reveal lottery is prevrandao; CI sometimes picks node_1. Assert exactly one winner and pay whoever won.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prevrandaolottery. The tests hardcoded node_5 as winner, which flakes on CI when node_1 is selected (isWinner(overlay_1_n_25)expected false).WinnerSelectedchecks off the actual winner.Fixes the failure on https://github.com/ethersphere/storage-incentives/actions/runs/33755478805.
Test plan
yarn test --grep "two commits with equal stakes"if both reveal, should select correct winnerno longer fails when node_1 wins the lottery