fix: resolve ty type check errors for CI

- Fix _load_claude_md_state return type to dict[str, Any] for nested JSON
- Add None guard for entry.source in reviews.py
- Import TypeAliasType from typing_extensions for Python 3.11 compat
- Add type: ignore for CORSMiddleware (known starlette typing issue)
- Remove stale type: ignore comments
- Install ty in dev dependencies (was declared but not installed)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: etoyama

pyproject.toml

@@ -114,4 +114,5 @@ sequence = ["lint", "typecheck", "test"]
 [dependency-groups]
 dev = [
     "httpx>=0.27",
+    "ty>=0.0.17",
 ]

src/insight_blueprint/core/reviews.py

@@ -375,7 +375,11 @@ def save_extracted_knowledge(
             comment_keys: dict[str, list[str]] = {}
             for entry in saved:
                 # source format: "review:{comment_id}@{design_id}"
-                if entry.source.startswith("review:") and "@" in entry.source:
+                if (
+                    entry.source
+                    and entry.source.startswith("review:")
+                    and "@" in entry.source
+                ):
                     comment_id = entry.source[len("review:") : entry.source.index("@")]
                     comment_keys.setdefault(comment_id, []).append(entry.key)
 

src/insight_blueprint/models/review.py

@@ -1,9 +1,10 @@
 """Pydantic data models for review comments (SPEC-3)."""
 
 from datetime import datetime
-from typing import Self, TypeAliasType
+from typing import Self
 
 from pydantic import BaseModel, Field, model_validator
+from typing_extensions import TypeAliasType
 
 from insight_blueprint.models.common import now_jst
 from insight_blueprint.models.design import DesignStatus

src/insight_blueprint/storage/project.py

@@ -11,6 +11,7 @@
 from datetime import UTC, datetime
 from importlib.resources.abc import Traversable
 from pathlib import Path
+from typing import Any
 
 from filelock import FileLock
 from packaging.version import InvalidVersion, Version
@@ -480,7 +481,7 @@ def _hash_content(content: str) -> str:
     return hashlib.sha256(content.replace("\r\n", "\n").encode("utf-8")).hexdigest()
 
 
-def _load_claude_md_state(project_path: Path) -> dict[str, str | None]:
+def _load_claude_md_state(project_path: Path) -> dict[str, Any]:
     """Load state for CLAUDE.md and rules from .claude/.insight-blueprint-state.json."""
     state_file = project_path / ".claude" / _STATE_FILENAME
     if not state_file.exists():
@@ -492,7 +493,7 @@ def _load_claude_md_state(project_path: Path) -> dict[str, str | None]:
         return {}
 
 
-def _save_claude_md_state(project_path: Path, state: dict[str, str | None]) -> None:
+def _save_claude_md_state(project_path: Path, state: dict[str, Any]) -> None:
     """Save state for CLAUDE.md and rules to .claude/.insight-blueprint-state.json."""
     state_file = project_path / ".claude" / _STATE_FILENAME
     state_file.parent.mkdir(parents=True, exist_ok=True)
@@ -593,7 +594,7 @@ def _copy_rules_template(project_path: Path) -> None:
     rules_dest.mkdir(parents=True, exist_ok=True)
 
     state = _load_claude_md_state(project_path)
-    rules_state: dict[str, dict[str, str | None]] = state.get("rules", {})  # type: ignore[assignment]
+    rules_state: dict[str, dict[str, str | None]] = state.get("rules", {})
     changed = False
 
     for rule_name in _discover_bundled_rules():
@@ -666,5 +667,5 @@ def _copy_rules_template(project_path: Path) -> None:
             )
 
     if changed:
-        state["rules"] = rules_state  # type: ignore[assignment]
+        state["rules"] = rules_state
         _save_claude_md_state(project_path, state)

src/insight_blueprint/web.py

@@ -26,7 +26,7 @@
 
 # CORS: allow localhost origins only
 app.add_middleware(
-    CORSMiddleware,
+    CORSMiddleware,  # type: ignore[arg-type]
     allow_origins=[
         "http://localhost:3000",
         "http://127.0.0.1:3000",