fix(ci): respect handler ratchet and recognize optional config bindings

Move analysis transport to its own v1 subpackage and teach config parity to recognize optional float bindings with a regression test.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: atulmgupta

docs/features/catalogue-tesla-physics.md

@@ -25,7 +25,7 @@ Sidebar group **Tesla Physics**. In the app, expand this section in the left nav
 
 ## Analysis boundaries
 
-New HTTP routes use `internal/handler/v1` and the `physicssvc` / `sciencesvc`
+New HTTP routes use `internal/handler/v1/analysis` and the `physicssvc` / `sciencesvc`
 application services. The ledger uses recorded intervals, exposes gaps and row
 caps, and does not reconcile partial telemetry against a complete session.
 Explicit `Disconnected` state, not latch release, denotes unplugging.

internal/api/router.go

@@ -407,6 +407,7 @@ import (
 	v1handlers "github.com/ev-dev-labs/teslasync/internal/handler/v1"
 	actioncenterhandler "github.com/ev-dev-labs/teslasync/internal/handler/v1/actioncenter"
 	advancedintelligencehandler "github.com/ev-dev-labs/teslasync/internal/handler/v1/advancedintelligence"
+	analysishandler "github.com/ev-dev-labs/teslasync/internal/handler/v1/analysis"
 	fleetstatehandler "github.com/ev-dev-labs/teslasync/internal/handler/v1/fleetstate"
 	ownershipintelhandler "github.com/ev-dev-labs/teslasync/internal/handler/v1/ownershipintel"
 	"github.com/ev-dev-labs/teslasync/internal/tracing"
@@ -1063,7 +1064,7 @@ func NewRouter(db *database.DB, teslaClient *tesla.Client, mqttClient *mqtt.Clie
 	// server-side, so the browser never downloads a raw counter history.
 	fsdInsightsHandler := apifsd.NewHandler(db)
 	physicsHandler := apiphysics.NewHandler(db, stateReader, liveStateReader)
-	physicsLedgerHandler := v1handlers.NewPhysicsLedgerHandler(physicssvc.New(db, stateReader, cfg))
+	physicsLedgerHandler := analysishandler.NewPhysicsLedgerHandler(physicssvc.New(db, stateReader, cfg))
 	var scienceWeather sciencesvc.HistoryFetcher
 	if cfg.Physics.WeatherEnabled {
 		client := apistormguard.NewClient()
@@ -1079,7 +1080,7 @@ func NewRouter(db *database.DB, teslaClient *tesla.Client, mqttClient *mqtt.Clie
 			return out, nil
 		}
 	}
-	scienceHandler := v1handlers.NewScienceHandler(sciencesvc.New(db, stateReader, cfg, scienceWeather))
+	scienceHandler := analysishandler.NewScienceHandler(sciencesvc.New(db, stateReader, cfg, scienceWeather))
 	if mqttClient != nil {
 		physicsHandler.WithMQTTConnected(func() *bool {
 			connected := mqttClient.IsConnected()

internal/handler/v1/analysis_handler.go …/handler/v1/analysis/analysis_handler.gointernal/handler/v1/analysis_handler.go renamed to internal/handler/v1/analysis/analysis_handler.go internal/handler/v1/analysis_handler.go renamed to internal/handler/v1/analysis/analysis_handler.go

@@ -1,4 +1,4 @@
-package v1
+package analysis
 
 import (
 	"context"

…rnal/handler/v1/analysis_handler_test.go …ler/v1/analysis/analysis_handler_test.gointernal/handler/v1/analysis_handler_test.go renamed to internal/handler/v1/analysis/analysis_handler_test.go internal/handler/v1/analysis_handler_test.go renamed to internal/handler/v1/analysis/analysis_handler_test.go

@@ -1,4 +1,4 @@
-package v1
+package analysis
 
 import (
 	"net/http/httptest"

internal/handler/v1/analysis/doc.go

@@ -0,0 +1,4 @@
+// Package analysis provides thin v1 HTTP transport for physics and science reports.
+//
+// Layer: handler
+package analysis

…nal/handler/v1/physics_ledger_handler.go …er/v1/analysis/physics_ledger_handler.gointernal/handler/v1/physics_ledger_handler.go renamed to internal/handler/v1/analysis/physics_ledger_handler.go internal/handler/v1/physics_ledger_handler.go renamed to internal/handler/v1/analysis/physics_ledger_handler.go

@@ -1,4 +1,4 @@
-package v1
+package analysis
 
 import (
 	"context"

internal/handler/v1/science_handler.go …l/handler/v1/analysis/science_handler.gointernal/handler/v1/science_handler.go renamed to internal/handler/v1/analysis/science_handler.go internal/handler/v1/science_handler.go renamed to internal/handler/v1/analysis/science_handler.go

@@ -1,4 +1,4 @@
-package v1
+package analysis
 
 import (
 	"context"

internal/ops/parity.go

@@ -65,7 +65,7 @@ type ParitySnapshot struct {
 }
 
 var (
-	goEnvRe       = regexp.MustCompile(`env(?:Str|Bool|Int|Int64|Float|Float64|Duration|StringSlice|CSV)\(\s*"([A-Z][A-Z0-9_]*)"`)
+	goEnvRe       = regexp.MustCompile(`env(?:Str|Bool|Int|Int64|Float|Float64|OptionalFloat64|Duration|StringSlice|CSV)\(\s*"([A-Z][A-Z0-9_]*)"`)
 	goGetenvRe    = regexp.MustCompile(`(?:os\.Getenv|getenv|LookupEnv)\(\s*"([A-Z][A-Z0-9_]*)"`)
 	helmDataKeyRe = regexp.MustCompile(`(?m)^\s{2}([A-Z][A-Z0-9_]*):`)
 	composeKVRe   = regexp.MustCompile(`^([A-Z][A-Z0-9_]*)\s*[:=]`)

internal/ops/parity_test.go

@@ -108,6 +108,16 @@ func TestExtractGoEnvVars(t *testing.T) {
 	if strings.Join(got, ",") != strings.Join(want, ",") {
 		t.Fatalf("got %v, want %v", got, want)
 	}
+
+}
+
+func TestExtractOptionalFloatBindings(t *testing.T) {
+	source := `var mass = envOptionalFloat64("TESLASYNC_VEHICLE_MASS_KG")
+var dynamic = envOptionalFloat64(variableName)`
+	got := ExtractGoEnvVars(source)
+	if len(got) != 1 || got[0] != "TESLASYNC_VEHICLE_MASS_KG" {
+		t.Fatalf("optional float binding not recognized: %v", got)
+	}
 }
 
 // TestExtractComposeEnvVars_BothFormsAndServiceScoping pins the two