fix(web): repoint and harden rotted frontend audit targets

Five of the ten failing audits were not code defects, they were audit rot.
PR #64 (refactor/filters) renamed or deleted several pages these audits point
at, and the audits silently skipped the very files they exist to guard.

Path rot:
- audit-inline-help: the notification-channels target pointed at a deleted
  NotificationChannelsView.tsx. Repointed at components/channels/ so further
  decomposition cannot rot it again. Coverage went 22 -> 27 (min 25) from the
  repoint alone, meaning the audit had been passing vacuously.
- audit-virtualization, audit-export-adoption: repointed post-rename paths.

Logic bugs:
- audit-deferred-filter grepped the *page* file for React.memo on a row
  component defined elsewhere, so an already-memoised DriveCard read as a
  violation. Targets now carry rowComponentPath and the check reads the
  component's defining file, accepting `export const X = memo(XImpl, ...)`.
- audit-filterbar-chips did not skip co-located *.test.tsx, contradicting its
  own documented __tests__ skip intent.

Anti-rot: stale PENDING_MIGRATION paths in audit-virtualization and
audit-export-adoption now hard-fail instead of printing "(file missing)" and
exiting 0. A path that no longer exists is now a build break, not a silent
pass, so this class of decay cannot recur unnoticed.

Also adds two justified allow-list entries: RadioCard.tsx to audit-sr-only
(identical `peer sr-only` case to the already-exempt Checkbox.tsx, where
VisuallyHidden would break the peer sibling relationship) and lib/cn.test.ts
to auditMotionTokens (the test asserts on raw duration-* strings by design).

Every change here was mutation-verified: break the rule -> exit 1,
restore -> exit 0.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: atulmgupta

web/scripts/audit-deferred-filter.mjs

@@ -36,9 +36,15 @@ const ROOT = 'src';
 
 // Each TARGET is a path (relative to web/) and an optional row component
 // name. When `rowComponent` is set, the audit also requires that name
-// to appear inside a `memo(` call somewhere in the file — otherwise
-// the row will still re-render on every filter keystroke even though
-// the filter compute is deferred.
+// to be wrapped in `memo(` — otherwise the row will still re-render on
+// every filter keystroke even though the filter compute is deferred.
+//
+// `rowComponentPath` says WHERE that memo() wrapper lives. Row components
+// are routinely extracted out of the page into their own file (one exported
+// component per file, per the repo's monolith rule), and the memo() wrapper
+// travels with them. Without this the audit greps the page file, finds no
+// `memo(`, and reports a false positive against a component that is in fact
+// correctly memoised. Defaults to the page itself for inline row components.
 //
 // Server-driven targets are still listed: they must carry the
 // `deferred-filter:no` justification or the audit fails. That keeps
@@ -47,6 +53,7 @@ const TARGETS = [
   {
     path: join(ROOT, 'features', 'driving', 'pages', 'DrivesListPage.tsx'),
     rowComponent: 'DriveCard',
+    rowComponentPath: join(ROOT, 'features', 'driving', 'components', 'DriveCard.tsx'),
   },
   {
     path: join(ROOT, 'features', 'system', 'pages', 'CommandHistoryPage.tsx'),
@@ -146,14 +153,39 @@ function auditFile(target) {
 
   // Row-component memo() check — only when the target declares one.
   if (rowComponent) {
-    const memoNames = memoCallNamesIn(text);
-    if (!memoNames.has(rowComponent)) {
+    // Resolve where the component is actually defined. An extracted row
+    // component keeps its memo() wrapper in its own file, not in the page.
+    const declPath = target.rowComponentPath ?? path;
+    if (!existsSync(declPath)) {
+      offenders.push({
+        where: declPath,
+        why:
+          `Declared \`rowComponentPath\` for \`${rowComponent}\` does not ` +
+          `exist. Update web/scripts/audit-deferred-filter.mjs to re-point ` +
+          `this entry at the file that defines and memoises the row.`,
+      });
+      return;
+    }
+
+    const declText = declPath === path ? text : readFileSync(declPath, 'utf8');
+
+    // Accept either form:
+    //   export const DriveCard = memo(DriveCardImpl, areEqual)   ← extracted
+    //   const DriveCard = memo(function DriveCard() {...})        ← inline
+    // The first wraps a differently-named impl, so a plain
+    // `memo(DriveCard` substring search misses it.
+    const exportedMemo = new RegExp(
+      `(?:export\\s+)?const\\s+${rowComponent}\\s*(?::[^=]+)?=\\s*memo\\s*\\(`,
+    ).test(declText);
+    const memoNames = memoCallNamesIn(declText);
+
+    if (!exportedMemo && !memoNames.has(rowComponent)) {
       const declLine = locOfMatch(
-        text,
+        declText,
         new RegExp(`function\\s+${rowComponent}\\b|const\\s+${rowComponent}\\b`),
       );
       offenders.push({
-        where: declLine ? `${path}:${declLine}` : path,
+        where: declLine ? `${declPath}:${declLine}` : declPath,
         why:
           `Row component \`${rowComponent}\` must be wrapped in ` +
           `\`memo(${rowComponent}, areEqual?)\` so unchanged rows skip ` +

web/scripts/audit-export-adoption.mjs

@@ -68,7 +68,10 @@ const TARGET_FRAGMENTS = [
 // backlog stays visible. NOT a failure — there's nothing to enforce
 // `exportable` on if there's no <DataTable/>.
 const PENDING_MIGRATION = [
-  'features/notifications/pages/NotificationsPage.tsx',
+  // Successor to the deleted NotificationsPage.tsx (renamed in #64
+  // "Refactor/filters"). InboxPage is a thin shell; rows are mapped into
+  // <NotificationRow> inside InboxBody, so that is what must migrate.
+  'features/notifications/components/InboxBody.tsx',
   'features/notifications/pages/AlertRulesPage.tsx',
   'features/admin/pages/ApiLogsPage.tsx',
   'features/driving/pages/DrivesListPage.tsx',
@@ -265,11 +268,19 @@ if (skippedNoDataTable.length > 0) {
 // PENDING_MIGRATION — informational only. Mirror the pattern used by
 // audit-virtualization.mjs: surface backlog so future sweeps can
 // migrate raw `.map()` / `<table>` rows to <DataTable/> + exportable.
+//
+// A *stale* entry is a hard failure, not a warning: a path that no longer
+// exists silently stops auditing the surface it was meant to track, which
+// is how NotificationsPage.tsx rotted through #64.
 const pendingMissing = [];
 for (const rel of PENDING_MIGRATION) {
   const full = path.join(ROOT, rel);
   if (!existsSync(full)) {
     pendingMissing.push(rel);
+    failures.push({
+      file: rel,
+      reason: 'file not found (PENDING_MIGRATION is stale — repoint it at the renamed file or drop the entry)',
+    });
   }
 }
 if (PENDING_MIGRATION.length > 0) {

web/scripts/audit-filterbar-chips.mjs

@@ -46,6 +46,10 @@ function walk(dir) {
       continue;
     }
     if (!p.endsWith('.tsx')) continue;
+    // Same rationale as the __tests__ skip above: co-located `*.test.tsx`
+    // files mount <FilterBar> in isolation to exercise the primitive itself,
+    // so requiring a sibling <ActiveFilterChips> there tests nothing real.
+    if (p.endsWith('.test.tsx')) continue;
     auditFile(p);
   }
 }

web/scripts/audit-inline-help.mjs

@@ -62,7 +62,11 @@ const TARGETS = [
   },
   {
     name: 'notification-channels',
-    path: 'src/features/notifications/components/NotificationChannelsView.tsx',
+    // The former single-file NotificationChannelsView.tsx was decomposed into
+    // this directory (ChannelCard / ChannelFormModal / ChannelProvidersPanel /
+    // ChannelsGrid / ChannelStatsBand). Point at the directory so the target
+    // survives further decomposition inside it.
+    path: 'src/features/notifications/components/channels',
     min: 4,
   },
 ];

web/scripts/audit-sr-only.mjs

@@ -45,11 +45,15 @@ const ROOT = join('src');
  * so Tailwind `peer-*:` variants on the indicator can read its state
  * while it stays in the accessibility tree. Wrapping it in
  * `<VisuallyHidden>` would break the `peer` sibling relationship.
+ * - `RadioCard.tsx` is the same pattern for `<input type="radio">`: the
+ * card body reads `peer-checked:` / `peer-focus-visible:` off the native
+ * input, so the input has to stay a direct `peer` sibling.
  */
 const ALLOWED_FILES = new Set([
   toAllowKey(join('src', 'components', 'a11y', 'VisuallyHidden.tsx')),
   toAllowKey(join('src', 'components', 'a11y', '__tests__', 'VisuallyHidden.test.tsx')),
   toAllowKey(join('src', 'components', 'ui', 'Checkbox.tsx')),
+  toAllowKey(join('src', 'components', 'ui', 'RadioCard.tsx')),
 ]);
 
 function toAllowKey(p) {

web/scripts/audit-virtualization.mjs

@@ -41,7 +41,6 @@ const ROOT = path.resolve(process.cwd(), 'src');
 // given prompt (READ-only — modifications still go through the normal
 // allowlist gate).
 const HOT_TABLE_PAGES = [
-  'features/notifications/pages/AlertsPage.tsx',
   'features/admin/pages/LiveLogsPage.tsx',
   'features/charging/pages/TeslaChargingSessionsPage.tsx',
   'features/charging/pages/TeslaChargingHistoryPage.tsx',
@@ -54,7 +53,14 @@ const HOT_TABLE_PAGES = [
 // component that doesn't exist; document the gap so the future work can
 // migrate them to DataTable+virtualized.
 const PENDING_MIGRATION = [
-  'features/notifications/pages/NotificationsPage.tsx',
+  // Successor to the deleted NotificationsPage.tsx (renamed in #64
+  // "Refactor/filters"). The page itself is a thin shell — rows are mapped
+  // into <NotificationRow> inside InboxBody, so that is what must migrate.
+  'features/notifications/components/InboxBody.tsx',
+  // Successor to the deleted AlertsPage.tsx (same PR). Renders rows via a
+  // raw .map() rather than <DataTable/>, so it cannot satisfy HOT_TABLE_PAGES.
+  // Currently bounded by client-side Pagination, hence migration not urgent.
+  'features/notifications/pages/AlertsListPage.tsx',
   'features/admin/pages/ApiLogsPage.tsx',
   'features/driving/pages/DrivesListPage.tsx',
   'features/charging/pages/ChargingListPage.tsx',
@@ -221,11 +227,19 @@ if (exemptedWaiver.length > 0) {
 // PENDING_MIGRATION — informational only. These pages render long
 // lists via raw `.map()` and ought to migrate to DataTable+virtualized
 // in a follow-up. Surfaced as warnings so the backlog stays visible.
+//
+// A *stale* entry is a hard failure, not a warning: a path that no longer
+// exists silently stops auditing the surface it was meant to track, which
+// is how NotificationsPage.tsx/AlertsPage.tsx rotted through #64.
 const pendingMissing = [];
 for (const rel of PENDING_MIGRATION) {
   const full = path.join(ROOT, rel);
   if (!existsSync(full)) {
     pendingMissing.push(rel);
+    failures.push({
+      file: rel,
+      reason: 'file not found (PENDING_MIGRATION is stale — repoint it at the renamed file or drop the entry)',
+    });
   }
 }
 if (PENDING_MIGRATION.length > 0) {

web/scripts/auditMotionTokens.mjs

@@ -48,8 +48,14 @@ const PATTERN = /\bduration-(\d+)\b/g;
 // Files to skip (paths relative to web/src). The tokens module legitimately
 // references the raw `duration-NNN` form for documentation; excluding it
 // keeps the audit honest without forcing a circular reference.
+//
+// `lib/cn.test.ts` asserts that the custom `duration-fast|normal|slow` keys
+// were registered into twMerge's SAME class group as the built-in numeric
+// scale — proving that requires spelling a raw `duration-200` as test input.
+// It ships no CSS, so it cannot cause the timing drift this audit prevents.
 const IGNORED = new Set([
   'lib/tokens.ts',
+  'lib/cn.test.ts',
 ]);
 
 const files = globSync(FILE_GLOB, { cwd: ROOT });