Revert "fix(apps): convert Driving Dynamics coach efficiency + distance to account units"

This reverts commit b3ba60d.

Author: atulmgupta

apps/windows/TeslaSync.App.Core/Units/UnitConverters.cs

@@ -87,15 +87,4 @@ public static class UnitConverters
         PowerUnit.Kw => watts / 1000.0,
         _ => watts,
     };
-
-    /// <summary>
-    /// Convert an energy-efficiency value from the backend-native Wh-per-kilometre (<c>efficiency_wh_km</c>)
-    /// to the user's display distance unit. Efficiency per mile is larger than per km because a mile is
-    /// longer: Wh/mi = Wh/km * (metres per mile / metres per km). Mirrors the web efficiency unit handling.
-    /// </summary>
-    public static double EfficiencyFromWhPerKm(double whPerKm, DistanceUnit to) => to switch
-    {
-        DistanceUnit.Mi => whPerKm * (MetersPerMile / MetersPerKm),
-        _ => whPerKm,
-    };
 }

apps/windows/TeslaSync.App.Core/Units/UnitPref.cs

@@ -128,9 +128,6 @@ public static class UnitLabels
         _ => "W",
     };
 
-    /// <summary>The energy-efficiency unit label for a display distance unit (Wh/mi imperial, else Wh/km).</summary>
-    public static string EfficiencyLabel(DistanceUnit u) => u == DistanceUnit.Mi ? "Wh/mi" : "Wh/km";
-
     public static DistanceUnit DistanceFromLabel(string label) => label switch
     {
         "km" => DistanceUnit.Km,

apps/windows/TeslaSync.App.Tests/EfficiencyConverterTests.cs

@@ -115,7 +115,7 @@ public static DrivingDynamicsDisplay Project(
             MotorCharts: BuildMotorCharts(snapshot.MotorHistory, localizer),
             Efficiency: BuildEfficiency(stats, units, localizer),
             Summary: BuildSummary(stats, units, localizer),
-            Coach: BuildCoach(snapshot.Coach, units, localizer),
+            Coach: BuildCoach(snapshot.Coach, localizer),
             Analytics: BuildAnalytics(filteredDrives, model.Range, units, localizer),
             Tips: BuildTips(stats, localizer),
             AutomationName: $"{title}. {subtitle}");
@@ -442,7 +442,7 @@ private static SummaryStatsDisplay BuildSummary(MotorStats? stats, UnitPref unit
     }
 
     // ── 9. Driving Coach ─────────────────────────────────────────────────────────────────────────────────
-    private static CoachDisplay BuildCoach(CoachData? coach, UnitPref units, ILocalizer l)
+    private static CoachDisplay BuildCoach(CoachData? coach, ILocalizer l)
     {
         double score = coach?.OverallScore ?? 0;
         int total = coach?.TotalDrivesAnalyzed ?? 0;
@@ -451,7 +451,7 @@ private static CoachDisplay BuildCoach(CoachData? coach, UnitPref units, ILocali
         var weekly = BuildWeeklySeries(coach, l);
         var patterns = BuildPatterns(coach, l);
         var (recsHas, recs) = BuildRecommendations(coach, l);
-        var (perHas, perRows) = BuildPerDrive(coach, units);
+        var (perHas, perRows) = BuildPerDrive(coach);
 
         return new CoachDisplay(
             l.GetString("dynamics.coach.title", "Driving Coach"),
@@ -465,9 +465,9 @@ private static CoachDisplay BuildCoach(CoachData? coach, UnitPref units, ILocali
             segments,
             rows,
             l.GetString("dynamics.coach.avgEfficiency", "Avg Efficiency"),
-            $"{ScalarFormatters.FormatNumber(UnitConverters.EfficiencyFromWhPerKm(coach?.EfficiencyWhKm ?? 0, units.Distance), 0)} {UnitLabels.EfficiencyLabel(units.Distance)}",
+            $"{ScalarFormatters.FormatNumber(coach?.EfficiencyWhKm ?? 0, 0)} Wh/km",
             l.GetString("dynamics.coach.bestEfficiency", "Best Efficiency"),
-            $"{ScalarFormatters.FormatNumber(UnitConverters.EfficiencyFromWhPerKm(coach?.BestEfficiencyWhKm ?? 0, units.Distance), 0)} {UnitLabels.EfficiencyLabel(units.Distance)}",
+            $"{ScalarFormatters.FormatNumber(coach?.BestEfficiencyWhKm ?? 0, 0)} Wh/km",
             l.GetString("dynamics.coach.weeklyTrend", "Weekly Score Trend"),
             (coach?.WeeklyTrend.Count ?? 0) > 1,
             l.GetString("dynamics.coach.needWeeks", "Need at least 2 weeks of data for trend analysis."),
@@ -485,7 +485,7 @@ private static CoachDisplay BuildCoach(CoachData? coach, UnitPref units, ILocali
                 l.GetString("dynamics.coach.col.date", "Date"),
                 l.GetString("dynamics.coach.col.score", "Score"),
                 l.GetString("dynamics.coach.col.style", "Style"),
-                UnitLabels.EfficiencyLabel(units.Distance),
+                l.GetString("dynamics.coach.col.efficiency", "Wh/km"),
                 l.GetString("dynamics.coach.col.distance", "Distance"),
             ],
             perRows);
@@ -578,7 +578,7 @@ private static (bool, IReadOnlyList<CoachRecRow>) BuildRecommendations(CoachData
         return (true, rows);
     }
 
-    private static (bool, IReadOnlyList<CoachScoreRow>) BuildPerDrive(CoachData? coach, UnitPref units)
+    private static (bool, IReadOnlyList<CoachScoreRow>) BuildPerDrive(CoachData? coach)
     {
         var scores = coach?.PerDriveScores ?? System.Array.Empty<CoachDriveScore>();
         if (scores.Count == 0)
@@ -603,8 +603,8 @@ private static (bool, IReadOnlyList<CoachScoreRow>) BuildPerDrive(CoachData? coa
                 scoreStatus,
                 s.Style,
                 styleStatus,
-                ScalarFormatters.FormatNumber(UnitConverters.EfficiencyFromWhPerKm(s.Efficiency, units.Distance), 0),
-                $"{ScalarFormatters.FormatNumber(UnitConverters.DistanceFromSi(s.Distance * 1000.0, units.Distance), 0)} {UnitLabels.Label(units.Distance)}"));
+                ScalarFormatters.FormatNumber(s.Efficiency, 0),
+                $"{ScalarFormatters.FormatNumber(s.Distance, 0)} km"));
         }
 
         return (true, rows);