feat(windows): mount full Appearance/General/Advanced surfaces in Settings

The Settings page was a thin hub (theme picker + export/tour/checklist links) while the rich AppearanceSettings (theme + density + sidebar + time-format + chart-palette + status-bar + celebrations), GeneralSettings, and AdvancedSettings surfaces existed but were never mounted. The shell now constructs them over a shared SettingsRepository (api+engine+options) and passes them to SettingsPage, which renders them (and disposes them). Falls back to the standalone theme panel when no surfaces are supplied.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: atulmgupta

apps/windows/TeslaSync.App/Shell/ShellWindow.xaml.cs

@@ -1287,6 +1287,26 @@ private void RegisterDataBackedPages()
                 new FeatureViews.Admin.LiveSignalInspectorClientFeed(_data.Api),
                 FeatureViews.Admin.EmptyLiveSignalsTableSource.Instance,
                 _data.Localizer));
+
+        // Settings hub — mount the full Appearance / General / Advanced settings surfaces (each backed by the
+        // shared settings repository over the live data layer) so the Settings page is a complete settings
+        // surface instead of a thin hub. The hub's navigation + tour-launcher wiring is preserved.
+        _viewModel.PageFactory.Register("Settings", () =>
+        {
+            var settingsRepo = new TeslaSync.App.Core.Data.Repositories.SettingsRepository(
+                _data.Api, _data.Engine, _data.Options);
+            var surfaces = new UIElement[]
+            {
+                FeatureViews.AppearanceSettings.Create(settingsRepo, _data.Api, _data.Localizer),
+                FeatureViews.GeneralSettings.Create(settingsRepo, _data.Api, _data.Localizer),
+                FeatureViews.AdvancedSettings.Create(_data.Localizer),
+            };
+            var page = new FeatureViews.Settings.SettingsPage(
+                FeatureViews.Settings.EmptySettingsFeed.Instance, _data.Localizer, surfaces);
+            page.NavigationRequested += (_, route) => NavigateTo(route);
+            page.TourLauncherRequested += (_, _) => NavigateTo("onboarding");
+            return page;
+        });
     }
 
     /// <summary>The shell's navigation/state view-model (exposed for diagnostics and tests).</summary>

apps/windows/TeslaSync.App/feature-views/SettingsPage/SettingsPage.cs

@@ -73,7 +73,11 @@ public sealed partial class SettingsPage : UserControl, IDisposable
     private readonly TsButton _checklistButton = new() { Variant = ButtonVariant.Subtle, IconGlyph = SettingsRegistration.ChecklistGlyph };
 
     // Appearance — accent palette + display-mode picker (native ThemeProvider parity, applied app-wide).
-    private readonly TsGlassPanel _themePanel;
+    // Null when the shell mounts the full Appearance surface (which already contains the theme picker).
+    private readonly TsGlassPanel? _themePanel;
+
+    // Optional full settings surfaces (Appearance / General / Advanced) mounted by the shell with the live data layer.
+    private readonly IReadOnlyList<UIElement> _extraSurfaces;
 
     /// <summary>Creates the page over the default (empty) settings feed and the shell resource localizer.</summary>
     public SettingsPage()
@@ -84,11 +88,12 @@ public SettingsPage()
     /// <summary>Creates the page over an explicit settings feed and localizer (used by tests / dependency injection).</summary>
     /// <param name="feed">The settings-read data port (web <c>useSettings</c>).</param>
     /// <param name="localizer">The i18n facade every label resolves through.</param>
-    public SettingsPage(ISettingsFeed feed, ILocalizer localizer)
+    public SettingsPage(ISettingsFeed feed, ILocalizer localizer, IReadOnlyList<UIElement>? extraSurfaces = null)
     {
         ArgumentNullException.ThrowIfNull(feed);
         ArgumentNullException.ThrowIfNull(localizer);
 
+        _extraSurfaces = extraSurfaces ?? System.Array.Empty<UIElement>();
         _viewModel = new SettingsPageViewModel(feed, localizer);
 
         // Web mounts <SettingsSearch /> at the top of the page; the search forwards a deep-link the host navigates to.
@@ -104,7 +109,7 @@ public SettingsPage(ISettingsFeed feed, ILocalizer localizer)
         BuildExportPanel();
         BuildTourPanel();
         BuildChecklistPanel();
-        _themePanel = BuildThemePanel(localizer);
+        _themePanel = _extraSurfaces.Count == 0 ? BuildThemePanel(localizer) : null;
 
         _container = new PageContainer(localizer, _viewModel.Display.Title)
         {
@@ -160,7 +165,20 @@ private StackPanel BuildBody()
         stack.Children.Add(_checklistToast);
         stack.Children.Add(_search);
         stack.Children.Add(_conflictBanner);
-        stack.Children.Add(Fade(_themePanel, 170));
+        if (_extraSurfaces.Count > 0)
+        {
+            int surfaceDelay = 170;
+            foreach (var surface in _extraSurfaces)
+            {
+                stack.Children.Add(Fade(surface, surfaceDelay));
+                surfaceDelay += 20;
+            }
+        }
+        else if (_themePanel is not null)
+        {
+            stack.Children.Add(Fade(_themePanel, 170));
+        }
+
         stack.Children.Add(Fade(_exportLink, 180));
         stack.Children.Add(Fade(_tourPanel, 200));
         stack.Children.Add(Fade(_checklistPanel, 220));
@@ -359,6 +377,12 @@ public void Dispose()
         _conflictBanner.Dispose();
         _container.Dispose();
         _viewModel.Dispose();
+
+        foreach (var surface in _extraSurfaces)
+        {
+            (surface as IDisposable)?.Dispose();
+        }
+
         GC.SuppressFinalize(this);
     }