chore(phase-43a): orphan hook disposition (useAlerts, useDashboardLayouts)

Adds web/src/api/hooks/orphan-allowlist.ts documenting two intentional
ORPHAN waivers per phase-43a/0001:

  - useAlerts.ts: domain-named re-export shim from Phase-45/32 (PR #61);
    call sites still import from useNotifications. Adoption pending.
  - useDashboardLayouts.ts: named-layout library hooks with LIVE backend
    routes (/dashboard/layouts/*) but the UI integration with
    LayoutSwitcher / DashboardPage is not yet wired (out of scope for
    this prompt; deferred to a future re-mount prompt).

Plus a documented baseline-fix sweep for 8 pre-existing lint failures
(4 ESLint no-extra-semi/unused-disable, 4 audit:query-signal AbortSignal
threading) so cd web && npm run lint passes end-to-end. Each baseline
fix is a single-line edit unrelated to orphan disposition; explicit
scope expansion documented in the prompt log per Honesty Covenant 8.

See .github/prompts/db-refactor/logs/phase-43a-0001-orphans.log for the
full audit evidence, design rationale, and gate output.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: atulmgupta

.github/prompts/db-refactor/logs/phase-43a-0001-orphans.log

@@ -218,7 +218,7 @@ describe('subscribeSignals', () => {
 
   afterEach(() => {
     if (originalEventSource) {
-      ;(globalThis as { EventSource: unknown }).EventSource = originalEventSource
+      (globalThis as { EventSource: unknown }).EventSource = originalEventSource
     } else {
       delete (globalThis as { EventSource?: unknown }).EventSource
     }

web/src/api/__tests__/sseClient.test.ts

@@ -83,7 +83,7 @@ describe('useSignalChangeStream', () => {
   })
 
   afterEach(() => {
-    ;(global as { EventSource: unknown }).EventSource = originalEventSource
+    (global as { EventSource: unknown }).EventSource = originalEventSource
   })
 
   it('subscribes to the signal_change channel and surfaces typed events', () => {

web/src/api/hooks/__tests__/useSSE.test.tsx

@@ -0,0 +1,79 @@
+/**
+ * orphan-allowlist — intentional ORPHAN hook waiver list (Phase-43a/0001).
+ *
+ * The phase-43 hook coverage audit (`phase-43-0080-hook-coverage-audit.log`)
+ * flags any file under `web/src/api/hooks/` whose exported `use*` symbols
+ * have ZERO production consumers. By default an ORPHAN status BLOCKS the
+ * audit. Files listed here are exempted: the audit treats listed entries as
+ * PASS and continues without erroring.
+ *
+ * Honesty Covenant rule 11 — "no dead code retention" — REQUIRES that any
+ * file added here have a documented reason and (where applicable) a link
+ * to a backlog issue tracking the future mount. Adding an entry without a
+ * reason or without committing to a future cleanup IS dead-code retention
+ * by stealth and SHOULD be rejected in code review.
+ *
+ * To remove an entry: either (a) wire the hook into a real consumer, or
+ * (b) delete the hook file. Both choices are preferable to growing the
+ * allowlist.
+ *
+ * Each entry's `file` is the bare filename relative to `web/src/api/hooks/`
+ * (no leading path, no `.ts` extension assumed by callers — match exactly
+ * as the hook coverage audit emits the name).
+ */
+
+export interface OrphanWaiver {
+  /** Bare filename, e.g. 'useAlerts.ts'. Must match the audit's file column. */
+  readonly file: string;
+  /** Why this hook is allowed to ship without a production consumer. */
+  readonly reason: string;
+  /**
+   * Tracking note for the future-mount work. Use a GitHub issue URL when
+   * one exists; a TODO marker is acceptable while the backlog item is
+   * still being filed.
+   */
+  readonly tracking: string;
+}
+
+export const INTENTIONAL_ORPHANS: readonly OrphanWaiver[] = [
+  {
+    file: 'useAlerts.ts',
+    reason:
+      'Domain-named re-export shim introduced in Phase-45 (PR #61, commit a2010406). ' +
+      'Re-exports alert-specific symbols from useNotifications so future call sites ' +
+      'can import from @/api/hooks/useAlerts without pulling notification-channel ' +
+      'types. The shim has no callers today because every consumer (AlertsPage, ' +
+      'AlertFeedWidget) still imports directly from useNotifications; the shim is ' +
+      'kept available as the migration path.',
+    tracking:
+      'TODO(phase-43a): file backlog issue to migrate alert imports from ' +
+      "`@/api/hooks/useNotifications` to `@/api/hooks/useAlerts` and remove this " +
+      'waiver entry once migration is complete.',
+  },
+  {
+    file: 'useDashboardLayouts.ts',
+    reason:
+      'Named-layout library hooks (useNamedDashboardLayouts / useCreateDashboardLayout / ' +
+      'useUpdateDashboardLayout / useDeleteDashboardLayout / useApplyDashboardLayout) ' +
+      'introduced in Phase-40/30 (commit 8009c98e2). The backend routes at ' +
+      '/api/v1/dashboard/layouts/* are LIVE (see internal/api/router.go L963-970 and ' +
+      'internal/api/dashboard_layout_handler.go) but the LayoutSwitcher UI in ' +
+      'web/src/features/dashboard/components/LayoutSwitcher.tsx still operates on ' +
+      'local-state SavedDashboard[] passed via props, not on the per-row backend ' +
+      'library. The hooks are the missing client half of a half-finished feature.',
+    tracking:
+      'TODO(phase-43a): file backlog issue to wire LayoutSwitcher save-as-preset / ' +
+      'apply-preset flow into the named-layout hooks. Out of scope for this prompt ' +
+      "because integration touches features/dashboard/hooks/useDashboardLayout.ts " +
+      '(839 lines), LayoutSwitcher.tsx, and DashboardPage.tsx beyond the prompt budget.',
+  },
+] as const;
+
+/**
+ * True iff the given hook filename is intentionally allowed to be ORPHAN.
+ *
+ * @param file - bare filename relative to `web/src/api/hooks/`, e.g. `useAlerts.ts`
+ */
+export function isIntentionalOrphan(file: string): boolean {
+  return INTENTIONAL_ORPHANS.some((entry) => entry.file === file);
+}

web/src/api/hooks/orphan-allowlist.ts

@@ -35,9 +35,10 @@ export const fleetTelemetryKeys = {
 export function useFleetTelemetryCoverage() {
   return useQuery({
     queryKey: fleetTelemetryKeys.coverage,
-    queryFn: async (): Promise<FleetTelemetryCoverageResponse> => {
+    queryFn: async ({ signal }): Promise<FleetTelemetryCoverageResponse> => {
       const raw = await request<FleetTelemetryCoverageResponse>(
         '/tesla/fleet-telemetry/coverage',
+        { signal },
       )
       return {
         categories: raw.categories ?? [],

web/src/api/hooks/useFleetTelemetry.ts

@@ -210,8 +210,8 @@ function normalizeDescriptor(raw: RawAvailableResponse['signals'] extends (infer
 export function useAvailableSignals(vehicleId: number) {
   return useQuery({
     queryKey: signalKeys.available(vehicleId),
-    queryFn: async (): Promise<AvailableSignalsResponse> => {
-      const raw = await request<RawAvailableResponse>(`/signals/${vehicleId}/available`)
+    queryFn: async ({ signal }): Promise<AvailableSignalsResponse> => {
+      const raw = await request<RawAvailableResponse>(`/signals/${vehicleId}/available`, { signal })
       const signals = (raw.signals ?? []).map(normalizeDescriptor)
       return {
         vehicle_id: raw.vehicle_id,
@@ -242,8 +242,8 @@ interface RawLiveResponse {
 export function useLiveSignals(vehicleId: number) {
   return useQuery({
     queryKey: signalKeys.live(vehicleId),
-    queryFn: async (): Promise<LiveSignalsResponse> => {
-      const raw = await request<RawLiveResponse>(`/signals/${vehicleId}/live`)
+    queryFn: async ({ signal }): Promise<LiveSignalsResponse> => {
+      const raw = await request<RawLiveResponse>(`/signals/${vehicleId}/live`, { signal })
       const signals: Record<string, SignalEnvelope> = {}
       for (const [field, env] of Object.entries(raw.signals ?? {})) {
         signals[field] = normalizeEnvelope(env ?? null)
@@ -286,7 +286,7 @@ export function useSignalHistory(
   const hours = range.hours ?? 24
   return useQuery({
     queryKey: signalKeys.history(vehicleId, signalName, hours, range.from, range.to),
-    queryFn: async (): Promise<SignalHistoryResponseTyped> => {
+    queryFn: async ({ signal }): Promise<SignalHistoryResponseTyped> => {
       const usp = new URLSearchParams()
       if (range.from && range.to) {
         usp.set('from', range.from)
@@ -300,6 +300,7 @@ export function useSignalHistory(
       const qs = usp.toString()
       const raw = await request<RawHistoryResponse>(
         `/signals/${vehicleId}/${signalName}/history${qs ? `?${qs}` : ''}`,
+        { signal },
       )
       const data = (raw.data ?? []).map((row) => normalizeEnvelope(row))
       return {

web/src/api/hooks/useSignals.ts

@@ -381,7 +381,6 @@ export default function ClimateControlPage() {
     })),
     // Track the primitive `tempUnit` instead of the closure `convertTemp`
     // so non-temperature settings churn doesn't invalidate the memo.
-    // eslint-disable-next-line react-hooks/exhaustive-deps
     [chronoHistory, tempUnit],
   );
 

web/src/features/vehicle-systems/pages/ClimateControlPage.tsx

@@ -234,7 +234,6 @@ export default function TirePressurePage() {
     // unitPrefs.pressure is the only relevant primitive dep — depending on
     // the closure-captured `toDisplayPressure` would also work but referencing
     // the primitive keeps the dep list stable for memo invalidation.
-    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [history, unitPrefs.pressure]);
 
   /* ---- Table columns ---- */