lint: delete pre-existing dead helpers instead of suppressing them

Per review feedback: //nolint:unused directives on 28 pre-existing helpers (funcs, methods, vars, types, consts, struct field) were masking dead code rather than fixing it. Removed each helper after verifying zero callers within its declaring package (the unused linter is package-scoped and these are all unexported, so cross-package callers are impossible by construction).

Deleted symbols (20 files / 403 lines net removed):

  internal/ai/rag/pgvector.go               isProviderGateClosed

  internal/api/automation_handler_test_run  checkWebhookTokenUniqueness, errWebhookTokenDuplicate, duplicateTokenError, (*duplicateTokenError).Error

  internal/api/battery_cells_handler.go     frontendCell type

  internal/api/battery_handler.go           nominalRangeKm const

  internal/api/chatbot_handler.go           (*ChatbotHandler).queryVehicleLocation

  internal/api/export_handler.go            ptrFloatMpsToMphAPI, ptrInt16

  internal/api/middleware.go                tracedTransport

  internal/api/polling_handler.go           writeJSONPolling

  internal/api/share_handler.go             (*ShareHandler).buildFromTelemetry

  internal/api/telemetry_handler.go         toBool, parseBuckleStatus, toTimestamp, (*TelemetryHandler).trackVehicleConfig, formatSignalName (+ var _ trick); also stale Phase-42 comments referencing deleted trackSecurity/trackUserPreferences

  internal/api/telemetry_sessions_signal_helpers.go  derefInt16AsInt

  internal/api/vehicle_settings_handler.go  drainBody

  internal/api/watch_handler.go             derefInt

  internal/automation/engine.go             Engine.mu field

  internal/database/settings_serializer.go  ptrInt64Eq

  internal/database/sudo_token_repo.go      (*SudoTokenStore).withClock

  internal/database/tesla_energy_history_repo.go  validJSON (+ orphan Helpers section header)

  internal/export/processor.go              ptrInt, ptrInt16

  internal/fsm/machine.go                   (*VehicleFSM).buildSignalContext

  internal/fsm/transition.go                guardNames

Also pruned the now-unused imports surfaced by the deletions:

  pgvector.go drops 'errors'; engine.go drops 'sync'; chatbot_handler.go drops 'strings'; polling_handler.go drops 'encoding/json'; telemetry_handler.go drops 'strconv', 'strings', 'github.com/rs/zerolog/log'; vehicle_settings_handler.go drops 'io'; tesla_energy_history_repo.go drops 'encoding/json'.

Verification (matches the CI matrix):

  go build ./... ✓   go vet ./... ✓   golangci-lint run ./... ✓ (0 issues)

  go test ./... ✓ all 157 packages   archmetrics -compare baseline.json ✓

  npx tsc --noEmit ✓ (frontend untouched)

Net effect: zero behavioural change, 28 //nolint:unused suppressions gone, no //nolint:unused // pre-existing directives remain anywhere in the tree.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: atulmgupta

internal/ai/rag/pgvector.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"crypto/sha256"
 	"encoding/hex"
-	"errors"
 	"fmt"
 	"time"
 
@@ -469,11 +468,3 @@ func (s *staticResolver) For(_ context.Context, _ string) (provider.Provider, er
 	return s.p, nil
 }
 
-// Helper: detect whether an error means "the resolver gate flipped
-// between calls" so a Retrieve loop can degrade silently rather than
-// spam the audit log.
-//nolint:unused // pre-existing func retained pending follow-up cleanup
-func isProviderGateClosed(err error) bool {
-	return errors.Is(err, provider.ErrProviderDisabled) ||
-		errors.Is(err, provider.ErrFeatureDisabled)
-}

internal/api/automation_handler_test_run.go

@@ -15,28 +15,6 @@ import (
 	"github.com/ev-dev-labs/teslasync/internal/models"
 )
 
-// checkWebhookTokenUniqueness verifies that no other automation uses the same
-// webhook_token. excludeID is the ID to skip (for updates); pass 0 for creates.
-//nolint:unused // pre-existing func retained pending follow-up cleanup
-func (h *AutomationHandler) checkWebhookTokenUniqueness(r *http.Request, config json.RawMessage, excludeID int64) error {
-	var cfg struct {
-		WebhookToken string `json:"webhook_token"`
-	}
-	if err := json.Unmarshal(config, &cfg); err != nil || cfg.WebhookToken == "" {
-		return nil // webhook token extraction not possible — skip check
-	}
-
-	existing, err := (*models.Automation)(nil), error(nil) // webhook token lookup removed in post-migration schema
-	if err != nil {
-		log.Warn().Err(err).Msg("webhook uniqueness check failed")
-		return nil // non-blocking: allow save on lookup failure
-	}
-	if existing != nil && existing.ID != excludeID {
-		return errWebhookTokenDuplicate
-	}
-	return nil
-}
-
 // ── Test Run ────────────────────────────────────────────────────────────
 
 // TestRun performs a dry-run of an automation: evaluates the trigger snapshot,
@@ -630,17 +608,6 @@ func validateActionConfig(cfg action.ActionConfig) error {
 	}
 }
 
-//nolint:unused // pre-existing var retained pending follow-up cleanup
-var errWebhookTokenDuplicate = &duplicateTokenError{}
-
-//nolint:unused // pre-existing type retained pending follow-up cleanup
-type duplicateTokenError struct{}
-
-//nolint:unused // pre-existing func retained pending follow-up cleanup
-func (e *duplicateTokenError) Error() string {
-	return "webhook_token is already in use by another automation"
-}
-
 // scrubWebhookSecrets removes webhook token fields from shared exports.
 func scrubWebhookSecrets(raw json.RawMessage) json.RawMessage {
 	var m map[string]interface{}

internal/api/battery_cells_handler.go

@@ -298,11 +298,3 @@ func (h *BatteryCellsHandler) getHistory(ctx context.Context, vehicleID int64) [
 	return points
 }
 
-// frontendCell matches the BatteryCell TypeScript interface.
-//nolint:unused // pre-existing type retained pending follow-up cleanup
-type frontendCell struct {
-	CellID      int     `json:"cell_id"`
-	Module      int     `json:"module"`
-	Voltage     float64 `json:"voltage"`
-	Temperature float64 `json:"temperature"`
-}

internal/api/battery_handler.go

@@ -63,8 +63,6 @@ func (h *BatteryHandler) Report(w http.ResponseWriter, r *http.Request) {
 
 	{
 		const nominalCapacity = 75000.0
-		//nolint:unused // pre-existing const retained pending follow-up cleanup
-		const nominalRangeKm = 531.0
 
 		if h.state != nil {
 			val, err := h.state.SignalAt(r.Context(), vehicleID, "EnergyRemaining", queryTime)

internal/api/chatbot_handler.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"errors"
 	"fmt"
-	"strings"
 
 	"github.com/ev-dev-labs/teslasync/internal/database"
 	"github.com/ev-dev-labs/teslasync/internal/service"
@@ -85,43 +84,6 @@ func (h *ChatbotHandler) vehicleLocationLine(ctx context.Context, vehicleID int6
 	return fmt.Sprintf("- **%s**: %.5f, %.5f", name, lat, lon), nil
 }
 
-// queryVehicleLocation answers "where is my car?" / "show me the location"
-// fleet-wide. For every vehicle owned by the user it derives the most
-// recent Latitude/Longitude pair via vehicleLocationLine (which itself
-// goes through signal.LiveStateReader) — never via a raw snapshot-table
-// lookup against `positions`, which would miss the last-known coordinates
-// for a vehicle that has been parked beyond the snapshot lookback window.
-//nolint:unused // pre-existing func retained pending follow-up cleanup
-func (h *ChatbotHandler) queryVehicleLocation(ctx context.Context) string {
-	if h.vehicleSvc == nil || h.live == nil {
-		return "I couldn't retrieve location info right now."
-	}
-	vehicles, err := h.vehicleSvc.VehicleRepo().GetAll(ctx)
-	if err != nil {
-		return "I couldn't retrieve location info right now."
-	}
-
-	var lines []string
-	for _, v := range vehicles {
-		if v == nil {
-			continue
-		}
-		name := v.DisplayName
-		if name == "" {
-			name = "Unknown"
-		}
-		line, err := h.vehicleLocationLine(ctx, v.ID, name)
-		if err != nil {
-			return "I couldn't retrieve location info right now."
-		}
-		lines = append(lines, line)
-	}
-	if len(lines) == 0 {
-		return "No vehicles found. Sync your fleet first."
-	}
-	return "**Vehicle Location:**\n" + strings.Join(lines, "\n")
-}
-
 // toFloat64 normalizes a signal.SignalValue (which is `any`) into a float64.
 // signal_log payloads can land as float64 (numeric column) or other numeric
 // kinds depending on which storage path the value came in on, so the helper

internal/api/export_handler.go

@@ -551,22 +551,3 @@ func ptrFloat(p *float64) float64 {
 	return 0
 }
 
-// ptrFloatMpsToMphAPI converts a nullable SI speed value (m/s) to mph for
-// the legacy CSV/JSON export shape served by the public /exports endpoints.
-// Slice 4 of phase-48 will rename the export column to max_speed_mps and
-// drop this conversion.
-//nolint:unused // pre-existing func retained pending follow-up cleanup
-func ptrFloatMpsToMphAPI(p *float64) float64 {
-	if p == nil {
-		return 0
-	}
-	return *p / 0.44704
-}
-
-//nolint:unused // pre-existing func retained pending follow-up cleanup
-func ptrInt16(p *int16) int {
-	if p != nil {
-		return int(*p)
-	}
-	return 0
-}

internal/api/middleware.go

@@ -215,10 +215,3 @@ func TracingMiddleware(next http.Handler) http.Handler {
 	)
 }
 
-//nolint:unused // pre-existing func retained pending follow-up cleanup
-func tracedTransport(base http.RoundTripper) http.RoundTripper {
-	if base == nil {
-		base = http.DefaultTransport
-	}
-	return otelhttp.NewTransport(base)
-}

internal/api/polling_handler.go

@@ -1,7 +1,6 @@
 package api
 
 import (
-	"encoding/json"
 	"net/http"
 	"strconv"
 
@@ -156,16 +155,6 @@ func pollEngineConfig(engine *polling.PollEngine) http.HandlerFunc {
 	}
 }
 
-// writeJSON is a helper that writes JSON responses.
-// If the api package already has one, this will be a duplicate — but it's
-// defined here as a fallback to avoid import cycles.
-//nolint:unused // pre-existing func retained pending follow-up cleanup
-func writeJSONPolling(w http.ResponseWriter, status int, data interface{}) {
-	w.Header().Set("Content-Type", "application/json")
-	w.WriteHeader(status)
-	json.NewEncoder(w).Encode(data) //nolint:errcheck
-}
-
 // POST /api/v1/polling/demo — seeds the engine with realistic test data so
 // the dashboard can be previewed without an authenticated Tesla account.
 func pollEngineDemo(engine *polling.PollEngine) http.HandlerFunc {

internal/api/share_handler.go

@@ -324,62 +324,6 @@ func (h *ShareHandler) buildPublicProfiles(ctx context.Context, resp *publicShar
 
 const clipPoints = 3 // number of points to clip from start/end for privacy
 
-//nolint:unused // pre-existing func retained pending follow-up cleanup
-func (h *ShareHandler) buildFromTelemetry(resp *publicShareResponse, readings []*models.DriveTelemetryReading, share *models.ShareToken) {
-	n := len(readings)
-	if n <= clipPoints*2 {
-		return
-	}
-
-	// Clip start and end points for privacy
-	clipped := readings[clipPoints : n-clipPoints]
-
-	var cumulativeDistM float64
-	var prevLat, prevLng float64
-
-	for i, tp := range clipped {
-		lat := derefFloat(tp.Latitude)
-		lng := derefFloat(tp.Longitude)
-
-		if lat == 0 && lng == 0 {
-			continue
-		}
-
-		// Accumulate distance
-		if i > 0 && prevLat != 0 {
-			cumulativeDistM += haversineKm(prevLat, prevLng, lat, lng) * 1000.0
-		}
-		prevLat, prevLng = lat, lng
-
-		if share.IncludeMap {
-			resp.MapPoints = append(resp.MapPoints, publicMapPoint{Lat: lat, Lng: lng})
-		}
-
-		if tp.Elevation != nil {
-			resp.ElevationProfile = append(resp.ElevationProfile, publicElevationPoint{
-				DistanceM:  cumulativeDistM,
-				ElevationM: *tp.Elevation,
-			})
-		}
-
-		if share.IncludeSpeed && tp.Speed != nil {
-			resp.SpeedProfile = append(resp.SpeedProfile, publicSpeedPoint{
-				DistanceM: cumulativeDistM,
-				SpeedMps:  *tp.Speed * 0.44704,
-			})
-		}
-
-		if share.IncludeTelemetry {
-			resp.Telemetry = append(resp.Telemetry, publicTelemetryPoint{
-				DistanceM:    cumulativeDistM,
-				BatteryLevel: tp.BatteryLevel,
-				Power:        tp.Power,
-				Elevation:    tp.Elevation,
-			})
-		}
-	}
-}
-
 func (h *ShareHandler) buildFromPositions(resp *publicShareResponse, positions []models.Position, share *models.ShareToken) {
 	n := len(positions)
 	if n <= clipPoints*2 {