Muse spark

[atulmgupta]

Description

Closes #

Type of Change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would break existing functionality)
• Documentation update
• Infrastructure / CI change

Checklist

• My code follows the project's style guidelines
• I have performed a self-review of my code
• I have added tests that prove my fix is effective or my feature works
• New and existing tests pass locally
• I have updated the documentation accordingly
• My changes generate no new warnings

Screenshots (if applicable)

[Copilot]

🟡 Changes recommended

Unresolved protobuf compatibility, production UI wiring, localization, normalization coverage, and CI gate issues remain.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds Tesla Fleet Telemetry fields 260–269 across schema generation, normalization, routing, and frontend live telemetry.

Changes:

• Updates the vendored Tesla schema, metadata, provenance, and routing.
• Adds kWh and mph SI conversions with tests.
• Extends frontend signal parsing and telemetry panels.
• Updates CI coverage and SI validation gates.

File summaries

File	Change / final review note
web/src/lib/signalCatalog.ts	Adds frontend signal metadata.
web/src/hooks/useVehicleLive.ts	Parses new signals. Moderate (2 votes): defaults erase missing-signal presence. Moderate (1 vote): add SSE and snapshot fixtures for new fields.
web/src/features/vehicles/components/telemetry-panels/VehicleStatePanel.tsx	Adds telemetry rows. Moderate (2 votes): format GPS accuracy through useUnits. Moderate (3 votes): add missing English catalog entries. Moderate (1 vote): component is not wired into the production detail page.
web/src/features/vehicles/components/telemetry-panels/VehicleStatePanel.test.tsx	Adds label coverage. Moderate (1 vote): add focused assertions for explicit and missing values.
web/src/features/vehicles/components/telemetry-panels/SecurityPanel.tsx	Adds remote-start status. Nit (1 vote): add the missing localization key and regenerate the catalog.
web/src/features/vehicles/components/telemetry-panels/SecurityPanel.test.tsx	Tests remote-start status.
web/src/features/vehicles/components/telemetry-panels/LiveTelemetryPanels.tsx	Composes new telemetry panels. Moderate (2 votes): this composition is not used by the production detail page.
internal/tesla/units/units.go	Applies mph conversion.
internal/tesla/units/units_test.go	Tests conversions. Moderate (1 vote): add pipeline-level coverage for new fixed-wire fields.
internal/tesla/units/conversions.go	Defines fixed conversions.
internal/tesla/router/routing.yaml	Routes new signals.
internal/tesla/protomodel/signal_metadata_gen.go	Adds generated metadata. Critical (1 vote): update the runtime protobuf dependency so fields 260–269 decode and route correctly.
internal/tesla/protomodel/coverage_test.go	Pins metadata coverage.
internal/tesla/normalize/normalize.go	Adds fixed-wire normalization. Moderate (1 vote): add end-to-end cases for both kWh and mph fields.
cmd/protogen-tesla/emit.go	Classifies new fields.
api/proto/tesla/VERSION	Updates the upstream revision.
api/proto/tesla/vehicle_data.proto	Adds fields 260–269.
api/proto/tesla/SOURCE.md	Records schema provenance. Nit (1 vote): distinguish the 2026-08-28 commit date from the 2026-09-14 fetch date.
api/proto/tesla/CHECKSUM	Updates the schema checksum.
.github/workflows/codec-coverage-gate.yml	Adjusts coverage runner selection. Moderate (2 votes): the arc-runner manual default cannot execute go test -race without GCC.
.github/scripts/si_canonical_gate.py	Adds the Tesla proto allowlist. Moderate (2 votes): only exempt the exact approved token so remaining banned identifiers are still checked.

Review details

Files not reviewed (1)

• internal/tesla/protomodel/signal_metadata_gen.go: Generated file

Suppressed comments (9)

api/proto/tesla/SOURCE.md:22

• The provenance table labels 2026-09-14 as the upstream commit date, but the pinned GitHub commit 8fbaa100bd365936dab6ecbf0e2d7070c4d765cb has an author/commit date of 2026-08-28; 2026-09-14 is the fetch date. Keep those dates accurate so the vendored schema's provenance is not misleading.

| Upstream commit date | 2026-09-14 |

internal/tesla/normalize/normalize.go:153

• The new fixed-wire branch is not covered end-to-end for the fields it adds: TestPipeline_FixedChargingKiloUnits still enumerates only the four existing AC/DC fields, and there is no pipeline case for either mph field. The unit-level tests prove ToSI, but they would not catch a regression in the new toSI/unit-history bypass; add pipeline cases for the two new kWh fields and both mph fields.

	if units.IsFixedMileDistanceField(atomic.Field) ||
		units.IsFixedKiloToBaseField(atomic.Field) ||
		units.IsFixedMphSpeedField(atomic.Field) {

internal/tesla/units/units_test.go:80

• These cases only verify units.ToSI; the normalize layer separately decides whether a field bypasses unit history. The existing pipeline-level fixed-wire test covers only AC/DC fields, so it would not catch either new kWh field or the new mph fields being omitted from normalize.toSI's fixed-wire condition and subsequently dropped when no unit-history row exists. Add the new fields to the pipeline-level table and assert that no history lookup occurs.

		{name: "LifetimeEnergyChargedKwh/kWh_to_Wh", field: "LifetimeEnergyChargedKwh", raw: 12.5, active: "", want: 12500, eps: epsTight},
		{name: "NominalFullPackEnergyKwh/kWh_to_Wh", field: "NominalFullPackEnergyKwh", raw: 100, active: ActiveUnitMiles, want: 100000, eps: epsTight},
		{name: "MaxSpeedToReachDestinationMph/mph_to_mps", field: "MaxSpeedToReachDestinationMph", raw: 65, active: "", want: 29.0576, eps: epsLoose},
		{name: "SemiCruiseSpeedLimitMph/mph_to_mps", field: "SemiCruiseSpeedLimitMph", raw: 55, active: "", want: 24.5872, eps: epsLoose},

web/src/features/vehicles/components/telemetry-panels/SecurityPanel.tsx:171

• telemetry.remoteStartActive is also not defined in the English source catalog or generated telemetry locale, so this newly added label can never resolve through the normal i18n catalog. Add the key to web/src/i18n/en.json and regenerate the split catalog.

              <KeyRound className="h-3 w-3" aria-hidden="true" /> {t('telemetry.remoteStartActive', 'Remote Start Active')}

web/src/features/vehicles/components/telemetry-panels/VehicleStatePanel.test.tsx:81

• This only adds the new labels to the broad presence check; it does not assert the new value branches (installing/available/current, remote-start active/inactive, GPS/grade values, or destination-speed formatting). A regression such as the false/zero defaults rendering Current/Off would remain green. Add focused assertions for explicit values and missing signals.

  'Software Update',
  'Remote Start Active',
  'GPS Accuracy',
  'Grade',
  'Max speed to destination',

web/src/features/vehicles/components/telemetry-panels/VehicleStatePanel.tsx:188

• When neither update signal is present, this ternary falls through to updateCurrent, so an empty live signal bag (and the useVehicleLive zero/false defaults) is displayed as a confirmed current software version. Check for nullish presence of both signals first and render an unknown placeholder unless at least one status was actually received.

            live.swUpdateInProgress
              ? t('telemetry.updateInstalling', 'Installing')
              : live.swUpdateAvailable
                ? t('telemetry.updateAvailable', 'Available')
                : t('telemetry.updateCurrent', 'Current')

web/src/features/vehicles/components/telemetry-panels/VehicleStatePanel.tsx:198

• undefined is treated as false here, so when RemoteStartActive has never been reported the panel says Off rather than unknown. Preserve the tri-state behavior used by SecurityPanel and show an em dash unless the signal is present.

          label={t('telemetry.remoteStartActive', 'Remote Start Active')}
          value={live.remoteStartActive ? t('common.active', 'Active') : offLabel}
          active={Boolean(live.remoteStartActive)}
          activeClass="text-amber-400"

web/src/features/vehicles/components/telemetry-panels/VehicleStatePanel.tsx:184

• These new rows are only rendered by LiveTelemetryPanels, but that composition has no production caller: VehicleDetailPage renders the separate vehicle-detail/* sections instead, and the remaining matches are re-exports/tests. Consequently the new software-update, remote-start, GPS, grade, and destination-speed UI is not visible on the vehicle detail page. Wire this composition into production or add the rows to the components that the page actually renders.

        <StateRow
          icon={Settings}
          label={t('telemetry.softwareUpdateAvailable', 'Software Update')}
          value={
            live.swUpdateInProgress

web/src/hooks/useVehicleLive.ts:409

• The hook tests cover both SSE parsing and initial snapshot hydration, but none of the newly added signal keys are exercised. A typo in any of these mappings or a boolean/number conversion regression would therefore leave the state at its defaults while the suite still passes. Add fixtures that assert the new fields through both update paths, including false and zero values.

  if (raw['GpsAccuracyMeters'] != null) s.gpsAccuracyM = n('GpsAccuracyMeters')
  if (raw['GradeEstimatePercent'] != null) s.gradeEstimatePct = n('GradeEstimatePercent')
  if (raw['MaxSpeedToReachDestinationMph'] != null) s.maxSpeedToDestinationMps = n('MaxSpeedToReachDestinationMph')
  if (raw['SemiCruiseSpeedLimitMph'] != null) s.semiCruiseSpeedLimitMps = n('SemiCruiseSpeedLimitMph')
  if (raw['LifetimeEnergyChargedKwh'] != null) s.lifetimeEnergyChargedWh = n('LifetimeEnergyChargedKwh')

• Files reviewed: 20/21 changed files
• Comments generated: 7
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Verify TypeScript build

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

[Copilot]

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Verify TypeScript build

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

[Copilot]

🟡 Changes recommended

Unresolved critical runtime-binding risk and multiple moderate correctness, UI, and CI issues remain.

Get a fresh assessment by requesting another Copilot review.

Review details

Files not reviewed (1)

• internal/tesla/protomodel/signal_metadata_gen.go: Generated file

Suppressed comments (11)

Previously missed (1) — in code that hasn't changed since the last review.

web/src/hooks/useVehicleLive.ts:408

• The hook has extensive parsing coverage, but no test exercises any of these newly added signal keys. A typo in one of the names or a numeric/boolean coercion regression would pass the suite; add a payload test covering the new numeric fields and both software/remote-start booleans.

.github/scripts/si_canonical_gate.py:91

• This exemption skips the entire added line when it contains any allowlisted Tesla identifier. A future line such as LegacyEnergyKwh = "NominalFullPackEnergyKwh" would therefore bypass the banned-identifier check. Only skip when every banned match on the line is an allowlisted identifier, rather than using a line-wide substring test.

        if any(name in added for name in TESLA_PROTO_FIELD_ALLOWLIST):
            continue

.github/workflows/codec-coverage-gate.yml:51

• The new runner expression still honors the workflow_dispatch input's default arc-runner (line 37). This job runs go test -race, and the comment above says that runner has no gcc, so a default manual dispatch will fail before the coverage tests run. Change the manual default to ubuntu-latest or otherwise prevent the unsupported runner from being selected.

    runs-on: ${{ github.event_name == 'workflow_dispatch' && inputs.runner || 'ubuntu-latest' }}

internal/tesla/normalize/normalize.go:153

• The new IsFixedMphSpeedField path is not covered at the pipeline level. Existing normalize tests cover the fixed-mile and fixed-kilo families, but no case exercises MaxSpeedToReachDestinationMph or SemiCruiseSpeedLimitMph through toSI; a regression here could make these samples consult unit history or drop them even though the lower-level conversion test passes. Add cases asserting the m/s value and that histRepo.At is not called.

	if units.IsFixedMileDistanceField(atomic.Field) ||
		units.IsFixedKiloToBaseField(atomic.Field) ||
		units.IsFixedMphSpeedField(atomic.Field) {

web/src/features/vehicles/components/telemetry-panels/LiveTelemetryPanels.tsx:84

• These new rows are only wired into LiveTelemetryPanels, but there is no production caller for that component; VehicleDetailPage renders SecuritySection and LiveStateIndicators instead. As a result, Remote Start Active and the new VehicleStatePanel fields will not appear in the shipped vehicle-detail UI. Wire the data into the actual page sections or mount this panel.

          <SecurityPanel
            securityData={securityData}
            remoteStartEnabled={remoteStartEnabled}
            remoteStartActive={remoteStartActive}
          />

web/src/features/vehicles/components/telemetry-panels/VehicleStatePanel.tsx:188

• The new telemetry.* keys used here (softwareUpdateAvailable, updateInstalling, updateAvailable, updateCurrent, and the other new telemetry labels) are not present under the canonical telemetry object in web/src/i18n/en.json; only inline fallbacks exist. The repository defines en.json as the sole hand-edited catalog source (web/scripts/split-i18n-catalog.mjs:5-7) and verifies its generated namespaces during the Vite build (web/vite.config.ts:59-66), so add these keys to the source and regenerate the locale namespaces instead of silently falling back to English.

          label={t('telemetry.softwareUpdateAvailable', 'Software Update')}
          value={
            live.swUpdateInProgress
              ? t('telemetry.updateInstalling', 'Installing')
              : live.swUpdateAvailable
                ? t('telemetry.updateAvailable', 'Available')
                : t('telemetry.updateCurrent', 'Current')

web/src/features/vehicles/components/telemetry-panels/VehicleStatePanel.tsx:204

• GpsAccuracyMeters is an SI distance, but this renders a hard-coded m suffix and bypasses the user's distance preference. useUnits() already exposes formatDistance, which converts SI meters and supplies the selected unit label; use that formatter here so km/mi settings are respected.

          label={t('telemetry.gpsAccuracy', 'GPS Accuracy')}
          value={typeof live.gpsAccuracyM === 'number' && Number.isFinite(live.gpsAccuracyM) ? `${live.gpsAccuracyM} m` : '—'}
        />

web/src/features/vehicles/components/telemetry-panels/VehicleStatePanel.tsx:204

• useVehicleLive initializes gpsAccuracyM, gradeEstimatePct, and maxSpeedToDestinationMps to 0 in EMPTY_STATE, so these numeric checks render invented 0 m, 0%, and zero speed before the corresponding signals have ever arrived. Preserve signal presence/nullable values or otherwise distinguish an unknown value and render the existing em-dash instead.

          value={typeof live.gpsAccuracyM === 'number' && Number.isFinite(live.gpsAccuracyM) ? `${live.gpsAccuracyM} m` : '—'}
        />

web/src/features/vehicles/components/telemetry-panels/VehicleStatePanel.tsx:188

• When live contains no software-update signals, both properties are absent and this falls through to updateCurrent. Missing telemetry is not evidence that the vehicle is current; render an unknown/em-dash state until at least one boolean has been observed, as the tri-state handling in SecurityPanel does for remote start.

            live.swUpdateInProgress
              ? t('telemetry.updateInstalling', 'Installing')
              : live.swUpdateAvailable
                ? t('telemetry.updateAvailable', 'Available')
                : t('telemetry.updateCurrent', 'Current')

web/src/features/vehicles/components/telemetry-panels/VehicleStatePanel.tsx:197

• With no RemoteStartActive key in the live map, this renders Off, even though the signal is simply unknown. SecurityPanel already distinguishes null from false; apply the same presence check here so an absent telemetry value is not presented as an inactive remote start.

          value={live.remoteStartActive ? t('common.active', 'Active') : offLabel}
          active={Boolean(live.remoteStartActive)}

web/src/hooks/useVehicleLive.ts:218

• These signals are only available from firmware 2026.32 (and SemiCruiseSpeedLimitMph is vehicle-specific), so older or unsupported vehicles legitimately omit them. Initializing the new fields to false/0 makes the UI report Current, Off, 0 m, 0%, or a zero speed before any sample is observed; preserve presence with nullable/undefined values or explicit signal-presence flags and render an unknown value until data arrives.

  europeVehicle: false, rightHandDrive: false, remoteStartEnabled: false, remoteStartActive: false, offroadLightbar: false,
  destinationName: '', destinationLatitude: 0, destinationLongitude: 0,
  distanceToArrival: 0, minutesToArrival: 0, routeLine: '',
  locatedAtHome: false, locatedAtWork: false, locatedAtFavorite: false,
  gpsState: '', gpsAccuracyM: 0, originLatitude: 0, originLongitude: 0,

• Files reviewed: 22/23 changed files
• Comments generated: 1
• Review effort level: Lite