fix(web): tolerate null drive-ledger dynamics on drive detail

[atulmgupta]

Summary

Drive detail pages (/drives/:id) showed Energy ledger failed to load because DriveLedgerCompactPanel read ledger.dynamics.regen_wh when Go encoded a missing nested ledger as JSON null (or the client omitted the key). That threw inside the drive-detail:energy-ledger error boundary.

Changes

• Optional-chain regen / friction-brake energy on DriveLedgerCompactPanel
• Type nested PhysicsLedger domains as | null to match Go pointers
• Regression test for JSON null and omitted dynamics

Test plan

• npx vitest run DriveLedgerCompactPanel + PhysicsLedgerPage
• npx tsc --noEmit
• docker compose build (api, web, workers)

How to verify

Open a drive like /drives/393. The energy ledger panel should render (Unknown regen/friction if dynamics is missing) instead of the error banner.

[Copilot]

🟡 Changes recommended

dynamics remains required even though omitted payloads are supported.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Updates drive-detail energy ledger rendering to tolerate missing or null physics dynamics.

Changes:

• Safely access regen and friction-brake values.
• Align nested ledger types with nullable API responses.
• Add regression tests for null, omitted, and populated dynamics.

File summaries

File	Summary
web/src/features/driving/components/drive-detail/DriveLedgerCompactPanel.tsx	Safely renders missing dynamics values.
web/src/features/driving/components/drive-detail/DriveLedgerCompactPanel.test.tsx	Tests null, omitted, and populated dynamics.
web/src/api/types.ts	Updates nested ledger nullability.

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Verify TypeScript build

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

[Copilot]

🔵 Needs a closer look

The TypeScript contract does not yet cover omitted dynamics and nullable points responses.

Review details

Suppressed comments (2)

web/src/api/types.ts:3798

• The new regression test explicitly deletes dynamics and the component now supports that undefined case, but this interface still declares the property as always present. If omitted keys are an accepted payload shape, make this property optional (dynamics?: PhysicsLongitudinalDynamics | null) so consumers are forced to handle both null and missing values; camelCaseKeys preserves present keys and does not make the required type accurate for an omitted source key.

  dynamics: PhysicsLongitudinalDynamics | null

web/src/api/types.ts:3798

• This nullable-contract update misses the nested points array. internal/physics/ledger.go declares LongitudinalDynamics.Points without omitempty, and dynamicsLedger passes the nil a.points slice when a window has no samples, so a non-null dynamics can still contain points: null; the TypeScript field remains PhysicsDynamicsPoint[]. Model PhysicsLongitudinalDynamics.points as PhysicsDynamicsPoint[] | null and add a null-points fixture so the contract matches the response that DynamicsPanel already normalizes with asList.

  // Nested ledgers are Go pointers; encoding/json emits null (or omits
  // after camelCase transforms) when that domain has no samples.
  dynamics: PhysicsLongitudinalDynamics | null

• Files reviewed: 3/3 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Copilot]

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Verify TypeScript build

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.