Conversation
The motivation behind the switch from `pdf2json` to `pdf-parse` was that the former was not able to correctly read the PDF:s generated by the updated Chromium version. Looking at the GitHub issues of that project showed that it was quite buggy and not really maintained anymore. `pdf-parse` on the other hand had no problem with PDF parsing, so the choice was easy.
Depending on the OS, Skia seems to render spaces and hyphens. When running tests it introduces some incosistencies, so we normalize both non-breaking spaces and soft hyphens to respective regular spaces and hyphens.
Upgrade puppeteer to 1.14
This came about because after running npm install we see the following: found 39 high severity vulnerabilities run `npm audit fix` to fix them, or `npm audit` for details
The previous image is no longer maintained also it does not even point to the correct source! See this issue: microbox/node-url-to-pdf-api#4 We have built a new image that we will maintain also in the future as part for Restorecommerce.
…rabilities Fixes lodash vulnerabilities by updating to latest revision
add option to create a browser by connecting to a chrome websocket endpoint
Point to different docker Image that is actually maintained
Use env-cmd to load .env file
Adding browser executable path option
…ealthcheck-endpoint Add healthcheck endpoint
…rade Revert "Node upgrade"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.