Repository navigation
refactor: remove unnecessary nuget packages references - #250
Merged
Merged
Conversation
… to resolve GHSA-v5pm-xwqc-g5wc Co-authored-by: kamilbaczek <74410956+kamilbaczek@users.noreply.github.com>
…nsitive deps Co-authored-by: kamilbaczek <74410956+kamilbaczek@users.noreply.github.com>
…in Chapter-4 to resolve GHSA-v5pm-xwqc-g5wc and MessagePack vulnerabilities Co-authored-by: kamilbaczek <74410956+kamilbaczek@users.noreply.github.com>
… to resolve GHSA-v5pm-xwqc-g5wc Co-authored-by: kamilbaczek <74410956+kamilbaczek@users.noreply.github.com>
…er 3 and 4 - Enable CentralPackageTransitivePinningEnabled in Chapter-3 Fitnet, Chapter-3 Contracts, Chapter-4 Fitnet - Upgrade Microsoft.OpenApi from 2.3.0 to 2.7.5 across all affected projects (resolves GHSA-v5pm-xwqc-g5wc) - Pin MessagePack 3.1.8 as transitive dependency to replace vulnerable 2.5.192 (resolves GHSA-hv8m-jj95-wg3x and related advisories) - Update Npgsql to 10.0.0 where needed to satisfy transitive requirements after enabling pinning Co-authored-by: kamilbaczek <74410956+kamilbaczek@users.noreply.github.com>
…ugets' into story/feature-remove-unnessery-nugets # Conflicts: # Chapter-4-applying-tactical-domain-driven-design/Fitnet.Contracts/Src/Directory.Packages.props Co-authored-by: kamilbaczek <74410956+kamilbaczek@users.noreply.github.com>
Testcontainers 4.0.0/4.7.0 pulls in SSH.NET 2024.2.0, which has a known high severity vulnerability (GHSA-q939-rpr3-3284). With NU1903 treated as an error, every integration test project failed to restore. Bump Testcontainers and Testcontainers.PostgreSql to 4.14.0, which depends on SSH.NET 2026.0.0. That version obsoletes the parameterless PostgreSqlBuilder, so the database containers now pass the image explicitly, matching the postgres:15.15 the AppHost already runs. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
kamilbaczek
changed the title
…s 3 and 4 The DataAccess projects in Offers and Passes use IApplicationBuilder but lost their Microsoft.AspNetCore.App framework reference, so CI failed with CS0234 and CS0246. Chapter 2 keeps that reference - restore it here too. The Contracts solutions never pinned Testcontainers, so the published IntegrationTestsToolbox package pulled Testcontainers 4.7.0 with the vulnerable SSH.NET 2024.2.0. Pin 4.14.0, which transitive pinning then applies to the toolbox as well. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
SSH.NET 2026.0.0, which Testcontainers 4.14.0 brings in, requires BouncyCastle.Cryptography 2.7.0 or higher. The central pin of 2.4.0 made restore fail with NU1109 package downgrade. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
=======================================
Coverage 16.90% 16.90%
=======================================
Files 67 67
Lines 562 562
Branches 10 10
=======================================
Hits 95 95
Misses 467 467 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.