Skip to content

chore(lint): install html lint to lint njk and html files, remo… - #1493

Draft
Natalie-Smirnova wants to merge 8 commits into
mainfrom
feat/html-linting
Draft

chore(lint): install html lint to lint njk and html files, remo…#1493
Natalie-Smirnova wants to merge 8 commits into
mainfrom
feat/html-linting

Conversation

@Natalie-Smirnova

Copy link
Copy Markdown
Collaborator

Closes: #1409

@Natalie-Smirnova Natalie-Smirnova self-assigned this Feb 20, 2023
Comment thread pages/views/search.njk Outdated
<esl-d-search-page-wrapper>
<div class="animation-loading bg-blue m-auto"></div>
<div class="gcse-search" data-resultsUrl="{{ '/search.html' | url }}"></div>
<div class="animation-loading bg-blue m-auto"></div>

@ala-n ala-n Feb 21, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as it is looked, it is incorrect. There should be two spaces instead of three

Comment thread pages/views/examples/toggleable.njk Outdated
Comment on lines +9 to +14
components:
- esl-toggleable
- esl-trigger
examples:
- accordion
- tabs

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's will not work.
Frontmetter it is yml syntax, so each indent matters.
So it is not right configuration here right now

@ala-n ala-n added this to the ⚡ESL 4.*.* Bugfix & support milestone Jun 23, 2023
@ala-n
ala-n force-pushed the main branch 6 times, most recently from 1f18a8a to 6506db7 Compare August 8, 2023 15:19
@ala-n ala-n removed this from the ⚡ESL 4.*.* Bugfix & support milestone Aug 8, 2023
@ala-n
ala-n force-pushed the main branch 4 times, most recently from df09192 to 5f44df3 Compare January 17, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🔧 linting]: consider replacing of the lint-space and html linter integration (require njk support)

2 participants