Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Node 24 in the Docker frontend build stage, matching the Node major already used by CI. Extracted from #2629 so the runtime upgrade can be reviewed independently. The final .NET runtime images and application configuration are unchanged.
Validation on Node 24.15.0:
npm ci, frontend validation, all 1,048 unit tests, and the production frontend build passed. These ran against the same main frontend source and lockfile in the navigation-fix checkout; its only source difference is an E2E assertion. Hosted CI will verify the Docker build and full test matrix.Reviewed the Node 24 release notes, including npm 11, V8, Undici, and deprecated APIs. This changes build tooling only. Node's October 21 security announcement affects both 22 and 24; this major-version update does not resolve that pending advisory. The existing NodeSource installation follows the selected major's current patch release.