Repository navigation
🐛 FIX: Correct included source line attribution - #1166
Closed
Sanjays2402 wants to merge 1 commit into
Closed
Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
Included Markdown applied a one-based offset before token maps were converted to one-based source lines, shifting every diagnostic down by one line. Pass the zero-based start line to the nested renderer and cover plain, start-line, and nested includes. Tests: python -m pytest -q Fixes executablebooks#1165
Member
|
Thank you @Sanjays2402, and apologies for the long wait. Yours was the first PR for #1165, with exactly the right one-token fix. We've landed it as part of #1169 (1915654), which also had to fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1165.
Included Markdown passed
startline + 1to a renderer that already converts zero-based token maps to one-based source lines. Passingstartlinekeeps diagnostics on the actual line; regression cases cover plain,:start-line:, and nested includes.Tested with
python -m pytest -q(1160 passed, 11 skipped).