Repository navigation
🐛 FIX: count lines, not characters, for {include} :start-after: - #1217
Closed
vishalkaay wants to merge 1 commit into
Closed
vishalkaay wants to merge 1 commit into
vishalkaay wants to merge 1 commit into
Conversation
The `:start-after:` option added the character index of the end of the marker to `startline`, which counts lines. Every line of the included content, and every warning raised in it, was shifted by the number of characters before the marker. Add the number of newlines consumed before the slice instead, and cover `:start-after:` alone and combined with `:start-line:` in the include error fixtures. Fixes executablebooks#1216
chrisjsewell
added a commit
that referenced
this pull request
Nov 10, 2026
Warnings raised inside an `{include}`d Markdown file now cite the file's
true lines. `startline + 1` was passed to `nested_render_text`, which
already applies the 0-based to 1-based conversion, so every line was
reported one line late (#1165); `:start-after:` advanced the line offset
by the marker's character index instead of the lines it skips (#1216);
and a negative `:start-line:` is now resolved to the line it counts from.
The tests are data-driven cases in `mock_include_errors.md`, including the
cases from #1184 and #1217 and edge cases for multi-line markers, CRLF
files, `end-before`, a marker ending the file and nested includes.
Fixes #1165, fixes #1216
Co-authored-by: dchaudhari7177 <dipakchaudhari171@gmail.com>
Co-authored-by: vishalkaay <vishalr23@iitk.ac.in>
Co-authored-by: Sanjay Santhanam <51058514+Sanjays2402@users.noreply.github.com>
Member
|
Thank you @vishalkaay, the line-counting fix for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1216
:start-after:added the marker's character index tostartline, so lines in the included content (and their warnings) were shifted by the number of characters before the marker. It now adds the number of lines consumed before the slice.Two cases in
mock_include_errors.mdcover:start-after:alone and together with:start-line:; without the fix they report lines 31 and 23 for a role on line 5.