Skip to content

🔧 Make the Codecov upload non-blocking - #167

Merged
chrisjsewell merged 3 commits into
masterfrom
maint/codecov-nonblocking
Nov 10, 2026
Merged

chrisjsewell merged 3 commits into
masterfrom
maint/codecov-nonblocking

Conversation

@chrisjsewell

Copy link
Copy Markdown
Member

Codecov stays, but it no longer decides whether CI passes.

  • The upload is skipped on Dependabot runs. Those runs get no repository secrets, so the upload always failed ("Token required because branch is protected") and blocked every Dependabot PR through the required checks.
  • fail_ci_if_error: false: any other upload failure (an outage, a token problem) is reported in the step log only.

Coverage is still measured and reported in the job log (--cov-report=term-missing) on every run.

Skip it on Dependabot runs (no secrets) and set fail_ci_if_error: false.
@codecov

codecov Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.65%. Comparing base (d11bdaf) to head (25f0fcc).
⚠️ Report is 33 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   92.80%   94.65%   +1.85%     
==========================================
  Files          31       40       +9     
  Lines        1835     2321     +486     
==========================================
+ Hits         1703     2197     +494     
+ Misses        132      124       -8     
Flag Coverage Δ
pytests 94.65% <ø> (+1.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chrisjsewell
chrisjsewell merged commit 3e689b0 into master Nov 10, 2026
13 checks passed
@chrisjsewell
chrisjsewell deleted the maint/codecov-nonblocking branch November 10, 2026 11:01
chrisjsewell added a commit that referenced this pull request Nov 10, 2026
State the grammar in the plugin docstring as rules: ASCII digits only,
the ASCII-letter look-ahead (a non-ASCII letter does not block a match),
no trailing dot, the nine-digit bound, the contexts where no reference
forms, and that \§ is not a backslash escape (the backslash stays
visible), with &sect; and &#167; giving a literal sign.

Pin the statements the fixtures did not cover yet with fixture rows:
non-ASCII digits, the two entities, an autolink and raw HTML.

Note that markdown-it-py's renderInlineAsText keeps only text tokens, so
a renderer that wants the reference in image alt text should use the
section_ref token's content.
chrisjsewell added a commit that referenced this pull request Nov 10, 2026
…tive (#169)

Pin every field of the section_ref token in a test, and say in the docstring
that the token shape is part of the public API from 0.7.0.

State the grammar as normative rules: ASCII digits only, 1 to 9 digits per
level, no trailing dot, the ASCII-letter look-ahead (a non-ASCII letter does
not block a match), no prefix match past the bound, and no reference inside
code spans, autolinks, inline math or raw HTML tags (text between two tags is inline text). Correct the escape wording:
\§ is not a CommonMark escape, so the backslash stays visible; &sect; and
&#167; give a literal sign. Add fixture rows for non-ASCII digits, the
entities, an autolink and raw HTML.

Note that renderInlineAsText keeps only text tokens, so a renderer that wants
the reference in image alt text should use the token's content.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant