Skip to content

Add say story - #2578

Merged
IsaacG merged 3 commits into
exercism:mainfrom
BNAndras:update-say-docs
Aug 8, 2025
Merged

Add say story#2578
IsaacG merged 3 commits into
exercism:mainfrom
BNAndras:update-say-docs

Conversation

@BNAndras

@BNAndras BNAndras commented Aug 7, 2025

Copy link
Copy Markdown
Member

@BNAndras
BNAndras requested a review from a team as a code owner August 7, 2025 21:21
Comment thread exercises/say/instructions.md Outdated

Examples:

- 0 → “zero”

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on "smart quotes"? I'm somewhat opposed to them. I don't think they are used uniformly throughout our md files.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't use them. I think (don't quote me) that they just get stripped out anyway on the way to the website - and they cause all manner of grief otherwise.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve, but I would feel better if this was smartquoteless. 😉

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also prefer this without any kind of quotes.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ll remove the quotes in a couple of hours.

@BethanyG

BethanyG commented Aug 7, 2025

Copy link
Copy Markdown
Member

Guess we need Jeremey.

@IsaacG

IsaacG commented Aug 7, 2025

Copy link
Copy Markdown
Member

Guess we need Jeremey.

Or @ErikSchierboom ;)

@IsaacG
IsaacG merged commit c9b3020 into exercism:main Aug 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants