[bob] Sort test cases - #2662
Merged
Merged
Conversation
Sort test cases based on the response and their order in the instructions. First test the simple versions of each response. Then test the more complex versions, ordered by response.
kotp
approved these changes
Jun 26, 2026
keiravillekode
approved these changes
Jun 27, 2026
BNAndras
approved these changes
Jun 27, 2026
| { | ||
| "uuid": "72bd5ad3-9b2f-4931-a988-dce1f5771de2", | ||
| "description": "other whitespace", | ||
| "uuid": "66953780-165b-4e7e-8ce3-4bcb80b6385a", |
Contributor
There was a problem hiding this comment.
This should have appeared earlier, line 103, before the test case that re-implements it.
Member
There was a problem hiding this comment.
I don’t think there’s a hard rule about that. For example, list-ops has tests that appear several slots after the ones they reimplement and svg-parsing has a test that implements the following test.
A test generator should be following the uuids not the test order to determine which test is reimplemented where.
Member
Author
There was a problem hiding this comment.
What @BNAndras said. Nothing here should rely on the order of the cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort test cases based on the response and their order in the instructions. First test the simple versions of each response. Then test the more complex versions, ordered by response.
This is a follow up to #2661