Skip to content

fix: skip code blocks when rewriting README links #2515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bjohansebas merged 3 commits into from
Oct 2, 2026
Merged

fix: skip code blocks when rewriting README links #2515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3d6f47
Fix broken URL in morgan.mdx custom format example
brmendez Sep 17, 2026
d1e257c
Apply Prettier formatting to morgan.mdx code block
brmendez Sep 17, 2026
aadbb97
Make link-rewrite regex skip fenced code blocks in get-readmes.sh
brmendez Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/scripts/get-readmes.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,11 @@ LIST_END
' <<<"$CONTENT")
fi

# Convert relative links to absolute GitHub URLs
# Convert relative links to absolute GitHub URLs. Skip fenced code blocks
# (lines between ``` markers): the regex can't tell a real markdown link
# from code that merely looks like one, e.g. `tokens['x'](req, res)`.
BASEURL="https://github.com/$org/$repo/blob/HEAD"
CONTENT=$(echo "$CONTENT" | sed -E "s|\]\(([^)#/][^):]*)\)|](${BASEURL}/\1)|g")
CONTENT=$(echo "$CONTENT" | sed -E "/^\`\`\`/,/^\`\`\`/!s|\]\(([^)#/][^):]*)\)|](${BASEURL}/\1)|g")

# Turn absolute self-links (https://expressjs.com/en/guide/x.html) into internal,
# language-agnostic paths (/guide/x) so they resolve on this site and get localized
Expand Down
10 changes: 6 additions & 4 deletions src/content/pages/en/resources/middleware/morgan.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,12 @@ morgan(function (tokens, req, res) {
tokens.method(req, res),
tokens.url(req, res),
tokens.status(req, res),
tokens.res(req, res, 'content-length'), '-',
tokens['response-time'](https://github.com/expressjs/morgan/blob/HEAD/req, res), 'ms'
].join(' ')
})
tokens.res(req, res, 'content-length'),
'-',
tokens['response-time'](req, res),
'ms',
].join(' ');
});
```

#### Options
Expand Down
Loading