Repository navigation
Revise error handling for server start events - #2540
Closed
JasanpreetSidhu wants to merge 2 commits into
Closed
JasanpreetSidhu wants to merge 2 commits into
JasanpreetSidhu wants to merge 2 commits into
Conversation
Callback passed to app.listen() runs only when the server starts successfully and It won't receive an error argument. so, need to attach the error handling code as a listener to the error event using server.on() method Signed-off-by: Jasan Sidhu <jasanpreetsinghsidhu@gmail.com>
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Since Express 5 the callback is also called on error. This is mentioned e.g. in the migration guide. The logic which implements it is here and it has been merged in expressjs/express#3216. This behaviour is tested and if for some reason it does not work, please open an issue in the express repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callback passed to app.listen() runs only when the server starts successfully and It won't receive an error argument. so, need to attach the error handling code as a listener to the error event using server.on() method