ISSUE #3100: Add support for different animations mode, reverse, ping pong, looping or not by 12alkry45 · Pull Request #3385 · f3d-app/f3d

12alkry45 · 2026-07-15T15:31:35Z

Describe your changes

Add --animation-mode and --animation-repeat CLI options. You can choose the mode of the animation: backward, forward or pingpong. Set the number of repeats to the animation.

Issue ticket number and link if any

ISSUE #3100: Add support for different animations mode, reverse, ping pong, looping or not

Checklist for finalizing the PR

I have performed a self-review of my code
I have added tests for new features and bugfixes
I have added documentation for new features
If it is a modifying the libf3d API, I have updated bindings
If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

AI Disclosure

I have not used AI to generate any of the content of this pull request
I have used AI to generate code in this pull request:
- I have carefully read and understood the AI policy.
- I have carefully reviewed and completely understood every generated line.
- I disclose below which parts of the code were generated and with which AI model:

...

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

mwestphal · 2026-07-15T16:24:28Z

@12alkry45 please disclose AI usage in the PR description

12alkry45 · 2026-07-15T17:29:35Z

@12alkry45 please disclose AI usage in the PR description

I only used Google (AI search) for internal/informational research. No code or PR text was generated by AI. Since I haven't completed the issue yet, I thought I'd check the box later, but, okay, it's indeed important, sorry)

mwestphal · 2026-07-15T19:27:14Z

@12alkry45 please disclose AI usage in the PR description

I only used Google (AI search) for internal/informational research. No code or PR text was generated by AI. Since I haven't completed the issue yet, I thought I'd check the box later, but, okay, it's indeed important, sorry)

No worries, we are being swamped by ai PRs atm, so we are checking right away.
Do not hesitate to modify the ai disclosure during the PR if you need to :)

12alkry45 · 2026-07-17T06:55:03Z

\ci fast

12alkry45 · 2026-07-17T07:02:46Z

Hello, @mwestphal , could you please review the code before I add tests and update docs? might be I have missed smth

github-actions · 2026-07-17T07:31:08Z

❌ Invalid CI command "fast"

12alkry45 · 2026-07-20T11:02:47Z

Hello, @mwestphal , could you please review the code before I add tests and update docs? might be I have missed smth

mwestphal · 2026-07-20T15:13:54Z

Sorry I missed this. Ill review.

mwestphal

That looks great! please move forward with doc and tests :)

mwestphal · 2026-08-20T08:01:53Z

+
+### `scene.animation.repeat` (_int_, default: `-1`)
+
+Specifies the number of animation repeat cycles. A value of `-1` means unlimited, while any integer sets a specific number of repeats.


what happens with 0 btw ?

Hmm... maybe the animation shouldn't run at all, so we need to add an additional condition in code (we have one tick before stop now)

mwestphal · 2026-08-20T08:03:03Z

+  };
+  AnimationModeType AnimationMode = AnimationModeType::FORWARD;
+  int AnimationMaxRepeat = -1;
+  int AnimationModeDirection = 1;


what is the point of this ?

Oops, you're right. That's a typo in the comment; it should be replaced with "Enum listing possible animation modes." The purpose of this code is to manage animation modes, repeat counts, and animation direction (depending on the mode).

mwestphal · 2026-08-20T08:03:19Z

  interactor_impl* Interactor = nullptr;

  int AvailAnimations = 0;
  int AnimationDirection = 1;


this should be removed

We can't remove this variable because the legacy code relies on it - for example, the logic for reversing the animation with hotkeys

then both logic should be merged

mwestphal

you should replace the "animation direction" stuff I think.

mwestphal · 2026-08-29T10:33:56Z

Need any help moving forward @12alkry45 ? :)

12alkry45 · 2026-08-30T08:02:31Z

Need any help moving forward @12alkry45 ? :)

Hi. Yes, I've been quite busy lately. I replied above, maybe I'm missing something here...

12alkry45 added 3 commits July 16, 2026 14:32

[feat] add cli options to animation mode and repeat

2f3c864

[feat] animation modes and repeat support in library

f84dfca

[feat] correct BACKWARD mode, initialising,nulling the count of repeats

dd6eb26

12alkry45 force-pushed the feat-animation-modes branch from 4f4554c to dd6eb26 Compare July 16, 2026 11:35

mwestphal added the ci:fast label Jul 17, 2026

mwestphal self-requested a review July 20, 2026 15:13

mwestphal reviewed Jul 20, 2026

View reviewed changes

12alkry45 added 2 commits July 20, 2026 22:08

[fix] add internal mode direction, process bar is working with modes

3f4f307

[docs] update docs with animation modes and repeats

031016f

mwestphal linked an issue Jul 29, 2026 that may be closed by this pull request

Add support for different animations mode, reverse, ping pong, looping or not #3100

Open

mwestphal self-requested a review August 6, 2026 14:29

12alkry45 added 3 commits August 6, 2026 19:23

[fix] toggling by space in pingpong mode

09c6cb2

[tests] add tests for different modes

d8ef127

[tests] add tests for animation repeats

cae3097

mwestphal reviewed Aug 20, 2026

View reviewed changes

mwestphal requested changes Aug 20, 2026

View reviewed changes


		### `scene.animation.repeat` (_int_, default: `-1`)

		Specifies the number of animation repeat cycles. A value of `-1` means unlimited, while any integer sets a specific number of repeats.

Uh oh!

Uh oh!

Conversation

12alkry45 commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes

Issue ticket number and link if any

Checklist for finalizing the PR

AI Disclosure

Continuous integration

Uh oh!

mwestphal commented Jul 15, 2026

Uh oh!

12alkry45 commented Jul 15, 2026

Uh oh!

mwestphal commented Jul 15, 2026

Uh oh!

12alkry45 commented Jul 17, 2026

Uh oh!

12alkry45 commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

12alkry45 commented Jul 20, 2026

Uh oh!

mwestphal commented Jul 20, 2026

Uh oh!

mwestphal left a comment

Choose a reason for hiding this comment

Uh oh!

mwestphal Aug 20, 2026

Choose a reason for hiding this comment

Uh oh!

12alkry45 Aug 30, 2026

Choose a reason for hiding this comment

Uh oh!

mwestphal Aug 20, 2026

Choose a reason for hiding this comment

Uh oh!

12alkry45 Aug 30, 2026

Choose a reason for hiding this comment

Uh oh!

mwestphal Aug 20, 2026

Choose a reason for hiding this comment

Uh oh!

12alkry45 Aug 30, 2026

Choose a reason for hiding this comment

Uh oh!

mwestphal Aug 30, 2026

Choose a reason for hiding this comment

Uh oh!

mwestphal left a comment

Choose a reason for hiding this comment

Uh oh!

mwestphal commented Aug 29, 2026

Uh oh!

12alkry45 commented Aug 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

12alkry45 commented Jul 15, 2026 •

edited

Loading

12alkry45 commented Jul 17, 2026 •

edited

Loading