Skip to content

#491: small Django 6.1 css update - #492

Open
jeroenpeters1986 wants to merge 3 commits into
fabiocaccamo:mainfrom
jeroenpeters1986:jeroenpeters1986-issue-491
Open

jeroenpeters1986 wants to merge 3 commits into
fabiocaccamo:mainfrom
jeroenpeters1986:jeroenpeters1986-issue-491

Conversation

@jeroenpeters1986

@jeroenpeters1986 jeroenpeters1986 commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

name: Pull request
about: Submit a pull request for this project
assignees: fabiocaccamo


Describe your changes

  • Just a little CSS line since they changes from a div to ol
  • Added Django 6.1 to the test-matrix

Related issue
#491

Checklist before requesting a review

Copilot AI lite review requested due to automatic review settings August 23, 2026 19:50
@codecov

codecov Bot commented Aug 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.48%. Comparing base (c41ec0c) to head (cbc2258).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #492   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files          40       40           
  Lines         438      438           
=======================================
  Hits          427      427           
  Misses         11       11           
Flag Coverage Δ
unittests 97.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Breadcrumb link color selectors still only target div.breadcrumbs, so on Django 6.1 the links inside ol.breadcrumbs won’t receive themed link/hover colors.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the admin-interface theme CSS to keep Django admin breadcrumbs themed after Django 6.1 changed the breadcrumbs container markup, and expands CI coverage to exercise Django 6.1.

Changes:

  • Update the breadcrumbs container selector to also target ol.breadcrumbs (Django 6.1 markup change).
  • Add Django 6.1 to the GitHub Actions test matrix for supported Python versions.
File summaries
File Description
admin_interface/static/admin_interface/css/admin-interface.css Extends breadcrumbs container theming to cover the Django 6.1 <ol class="breadcrumbs"> markup.
.github/workflows/test-package.yml Adds Django 6.1 to the CI matrix so tests run against the new Django version.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread admin_interface/static/admin_interface/css/admin-interface.css
@jeroenpeters1986

Copy link
Copy Markdown
Contributor Author

@fabiocaccamo I am sorry for the Copilot spam.. Appearantly it does this also on PR's even I just wanted it on my own repositories :-(

Comment thread admin_interface/static/admin_interface/css/admin-interface.css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants