Repository navigation
#491: small Django 6.1 css update - #492
jeroenpeters1986 wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #492 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 40 40
Lines 438 438
=======================================
Hits 427 427
Misses 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟡 Changes recommended
Breadcrumb link color selectors still only target div.breadcrumbs, so on Django 6.1 the links inside ol.breadcrumbs won’t receive themed link/hover colors.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the admin-interface theme CSS to keep Django admin breadcrumbs themed after Django 6.1 changed the breadcrumbs container markup, and expands CI coverage to exercise Django 6.1.
Changes:
- Update the breadcrumbs container selector to also target
ol.breadcrumbs(Django 6.1 markup change). - Add Django 6.1 to the GitHub Actions test matrix for supported Python versions.
File summaries
| File | Description |
|---|---|
| admin_interface/static/admin_interface/css/admin-interface.css | Extends breadcrumbs container theming to cover the Django 6.1 <ol class="breadcrumbs"> markup. |
| .github/workflows/test-package.yml | Adds Django 6.1 to the CI matrix so tests run against the new Django version. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@fabiocaccamo I am sorry for the Copilot spam.. Appearantly it does this also on PR's even I just wanted it on my own repositories :-( |
name: Pull request
about: Submit a pull request for this project
assignees: fabiocaccamo
Describe your changes
divtoolRelated issue
#491
Checklist before requesting a review