Repository navigation
Support empty and keyword updates in BaseDict - #633
Merged
fabiocaccamo merged 2 commits intoOct 20, 2026
Merged
fabiocaccamo merged 2 commits into
fabiocaccamo merged 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #633 +/- ##
=======================================
Coverage 98.69% 98.69%
=======================================
Files 65 65
Lines 2446 2449 +3
=======================================
+ Hits 2414 2417 +3
Misses 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fabiocaccamo
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaseDict.update()rejects empty calls and entry keywords such asupdate(name="Alice"), although its dictionary base class supports these forms.Make the source optional, use positional-only
selfandotherparameters, and forward entry keywords to the backing dictionary or native storage. Preserve keyword precedence, nested BaseDict normalization, and freeze checks. Five tests cover both storage modes and native-dict controls forself/otherkeys.Fourteen new subcases fail before this change. All 968 unittest cases, package mypy checks, Ruff lint and formatting pass.