Repository navigation
Fix #636: implement sized items and values views for benedict - #637
Merged
fabiocaccamo merged 4 commits intoOct 20, 2026
Merged
fabiocaccamo merged 4 commits into
fabiocaccamo merged 4 commits into
Conversation
…dict Serializers such as toml-rs inspect len() on mapping.items(), which previously failed with a TypeError because benedict.items() and benedict.values() returned generators. Replace generator returns with _BenedictItemsView and _BenedictValuesView inheriting from collections.abc.ItemsView and ValuesView while delegating to BaseDict to preserve dynamic mutation reflection and nested dict casting.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #637 +/- ##
==========================================
+ Coverage 98.69% 98.70% +0.01%
==========================================
Files 65 65
Lines 2446 2476 +30
==========================================
+ Hits 2414 2444 +30
Misses 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fabiocaccamo
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #636.
Summary
Serializers such as
toml-rsinspectlen()onmapping.items(), which previously failed withTypeError: object of type 'generator' has no len()becausebenedict.items()andbenedict.values()returned generators.This PR replaces the generator returns with
_BenedictItemsViewand_BenedictValuesViewinheriting fromcollections.abc.ItemsViewandValuesView, delegating iteration toBaseDictso mutations continue to be reflected and nested dictionaries are cast dynamically.