Repository navigation
Validate keypaths during in-place dictionary union - #643
Open
Gabrieljr42 wants to merge 1 commit into
Open
Gabrieljr42 wants to merge 1 commit into
Gabrieljr42 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
=======================================
Coverage 98.70% 98.70%
=======================================
Files 65 65
Lines 2476 2479 +3
=======================================
+ Hits 2444 2447 +3
Misses 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
b |= mappingbypasses the keypath checks used byb.update(mapping). With the default separator,b |= {'invalid.key': 1}stores an invalid literal key that cannot be accessed normally through keypaths, whileupdate()rejects the same input.Route
KeypathDict.__ior__through its validatedupdate()and return the same object. Regression coverage includes pointer-backed and unwrapped dictionaries, empty updates, custom/disabled separators, unchanged data after rejection, and frozen dictionaries.Validation: the new regression fails before the fix. The 120 focused dictionary/freeze tests and all pre-commit hooks, including Ruff and mypy, pass. A broader run passed 960 tests with 32 URL-dependent tests skipped; the complete suite could not finish against unreachable remote URL fixtures. No test configuration was changed.
Related issue
Newly reproduced bug; no existing issue found for this validation bypass.
Checklist before requesting a review
Implementation used a Luna agent, followed by a separate diff review and rerun of the focused tests and pre-commit hooks.