Prevent gen param name conflict

Author: alfonsogarciacaro

src/Fable.Transforms/FSharp2Fable.Util.fs

@@ -802,11 +802,8 @@ module TypeHelpers =
     open Patterns
 
     let genParamName (genParam: FSharpGenericParameter) =
-        // Sometimes the names of user-declared and compiler-generated clash, see #1900
-        //if genParam.IsCompilerGenerated then genParam.Name.Replace("?", "$") + "$" else genParam.Name
-
-        // Conflicting generic param names seem to have been solved in FCS
-        genParam.Name
+        // Sometimes the names of user-declared and compiler-generated clash, see #1900 and https://github.com/dotnet/fsharp/issues/13062
+        if genParam.IsCompilerGenerated then genParam.Name.Replace("?", "$") + "$" else genParam.Name
 
     let resolveGenParam ctxTypeArgs (genParam: FSharpGenericParameter) =
         let name = genParamName genParam

src/Fable.Transforms/FSharp2Fable.fs

@@ -349,7 +349,7 @@ let private transformUnionCaseTest (com: IFableCompiler) (ctx: Context) r
                     let name = genParamName fi.FieldType.GenericParameter
                     let index =
                         tdef.GenericParameters
-                        |> Seq.findIndex (fun arg -> arg.Name = name)
+                        |> Seq.findIndex (fun arg -> genParamName arg = name)
                     genArgs.[index]
                 else fi.FieldType
             let kind = makeType ctx.GenericArgs typ |> Fable.TypeTest
@@ -1793,16 +1793,7 @@ let getInlineExprs fileName (declarations: FSharpImplementationFileDeclaration l
                                 ctx, ident::idents)
 
                         // It looks as we don't need memb.DeclaringEntity.GenericParameters here
-                        let genArgsSet = HashSet()
-                        let genArgs = memb.GenericParameters |> Seq.mapToList (fun g ->
-                            let name = genParamName g
-                            if not(genArgsSet.Add(name)) then // See https://github.com/fable-compiler/repl/issues/152
-                                let r = makeRange memb.DeclarationLocation |> Some
-                                $"Two generic arguments with same name: %s{name}, have been detected for method %s{memb.FullName}. "
-                                + "This may happen when type inference conflicts with generic arguments for the class. "
-                                + "Please type explicitly the arguments of the method."
-                                |> addWarning com [] r
-                            name)
+                        let genArgs = memb.GenericParameters |> Seq.mapToList (genParamName)
 
                         { Args = List.rev idents
                           Body = com.Transform(ctx, body)

tests/Main/ReflectionTests.fs

@@ -129,7 +129,7 @@ type Service<'a> = {
     GetRecord: int -> int64 -> Async<'a>
 }
 with
-    static member inline RouteBuilder (_: 'b) m =
+    static member inline RouteBuilder _ m =
         let name = typeof<'a>.Name
         sprintf "/api/%s/%s" name m